Ensure test_fig_sigint_override cleans up global state.

QuLogic · QuLogic · commit f2740fd8bec3 · 2021-08-31T17:06:06.000-04:00
diff --git a/lib/matplotlib/tests/test_backend_qt.py b/lib/matplotlib/tests/test_backend_qt.py
@@ -214,29 +214,31 @@ def custom_handler(signum, frame):
 
     signal.signal(signal.SIGINT, custom_handler)
 
-    # mainloop() sets SIGINT, starts Qt event loop (which triggers timer and
-    # exits) and then mainloop() resets SIGINT
-    matplotlib.backends.backend_qt._BackendQT.mainloop()
+    try:
+        # mainloop() sets SIGINT, starts Qt event loop (which triggers timer
+        # and exits) and then mainloop() resets SIGINT
+        matplotlib.backends.backend_qt._BackendQT.mainloop()
 
-    # Assert: signal handler during loop execution is changed
-    # (can't test equality with func)
-    assert event_loop_handler != custom_handler
+        # Assert: signal handler during loop execution is changed
+        # (can't test equality with func)
+        assert event_loop_handler != custom_handler
 
-    # Assert: current signal handler is the same as the one we set before
-    assert signal.getsignal(signal.SIGINT) == custom_handler
+        # Assert: current signal handler is the same as the one we set before
+        assert signal.getsignal(signal.SIGINT) == custom_handler
 
-    # Repeat again to test that SIG_DFL and SIG_IGN will not be overridden
-    for custom_handler in (signal.SIG_DFL, signal.SIG_IGN):
-        qt_core.QTimer.singleShot(0, fire_signal_and_quit)
-        signal.signal(signal.SIGINT, custom_handler)
+        # Repeat again to test that SIG_DFL and SIG_IGN will not be overridden
+        for custom_handler in (signal.SIG_DFL, signal.SIG_IGN):
+            qt_core.QTimer.singleShot(0, fire_signal_and_quit)
+            signal.signal(signal.SIGINT, custom_handler)
 
-        _BackendQT5.mainloop()
+            _BackendQT5.mainloop()
 
-        assert event_loop_handler == custom_handler
-        assert signal.getsignal(signal.SIGINT) == custom_handler
+            assert event_loop_handler == custom_handler
+            assert signal.getsignal(signal.SIGINT) == custom_handler
 
-    # Reset SIGINT handler to what it was before the test
-    signal.signal(signal.SIGINT, original_handler)
+    finally:
+        # Reset SIGINT handler to what it was before the test
+        signal.signal(signal.SIGINT, original_handler)
 
 
 @pytest.mark.parametrize(
