fix leaked exception in RRuleLocator.tick_values

gnaggnoyil · gnaggnoyil · commit f2bb2181d387 · 2017-08-13T04:48:27.000+08:00
diff --git a/.gitignore b/.gitignore
@@ -14,6 +14,7 @@
 .pydevproject
 *.swp
 .idea
+.vscode/
 
 # Compiled source #
 ###################
diff --git a/lib/matplotlib/dates.py b/lib/matplotlib/dates.py
@@ -840,7 +840,7 @@ def tick_values(self, vmin, vmax):
         # We need to cap at the endpoints of valid datetime
         try:
             start = vmin - delta
-        except ValueError:
+        except (ValueError, OverflowError):
             start = _from_ordinalf(1.0)
 
         try:
diff --git a/lib/matplotlib/tests/test_dates.py b/lib/matplotlib/tests/test_dates.py
@@ -128,6 +128,23 @@ def test_RRuleLocator():
     fig.autofmt_xdate()
 
 
+def test_RRuleLocator_dayrange():
+    ret = 0
+
+    try:
+        loc = mdates.DayLocator()
+        x1 = datetime.datetime(year=1, month=1, day=1)
+        y1 = datetime.datetime(year=1, month=1, day=16)
+        loc.tick_values(x1, y1)
+    except OverflowError:
+       # On success, no overflow error shall be thrown
+       ret = 1
+    except:
+        pass
+    
+    assert ret == 0
+
+
 @image_comparison(baseline_images=['DateFormatter_fractionalSeconds'],
                   extensions=['png'])
 def test_DateFormatter():
