File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -165,6 +165,24 @@ C/C++ extensions
165165
166166
167167
168+ PR Review guidelines
169+ ====================
170+
171+ * We run on a 'use your judgement' system (for better or worse) and do
172+ not have a strict nose-count rule. If you have a commit bit, then
173+ you are trusted to use it and to know when to ask for more review.
174+
175+ * Do not self merge with the exception of un-breaking travis.
176+
177+ * Squashing is case-by-case. The balance is between burden on the
178+ contributor, keeping a relatively clean history, and keeping a
179+ history usable for bisecting. The only time we are really strict
180+ about it is to eliminate binary files (ex multiple test image
181+ re-generations) and to remove upstream merges.
182+
183+ * Be patient with new contributors.
184+
185+
168186Style guide
169187===========
170188
You can’t perform that action at this time.
0 commit comments