Correct the removal of -Wstrict-prototypes from compiler flags.

anntzer · anntzer · commit f9d757cefae0 · 2018-09-11T13:37:28.000+02:00
Trying to remove the invalid flag in run() was too early (.compiler is still None at that point so we would just always get a (silenced) AttributeError -- catching the AttributeError is necessary to make things work on Windows). Indeed, the Py3.5 build currently displays a lot of warnings about -Wstrict-prototypes. Doing the removal in build_extensions() instead works. This went unnoticed because the upstream issue in distutils (https://bugs.python.org/issue5755) was recently fixed in Py3.6.6 and 3.7.0; but this still affects Py3.5 and Py3.6.{0-5}.
diff --git a/setup.py b/setup.py
@@ -107,15 +107,16 @@ def __init__(self, dist):
 
 
 class BuildExtraLibraries(BuildExtCommand):
-    def run(self):
-        # Remove the -Wstrict-prototypes option, it's not valid for C++.
+    def build_extensions(self):
+        # Remove the -Wstrict-prototypes option, it's not valid for C++.  Fixed
+        # in Py3.7 as bpo-5755.
         try:
             self.compiler.compiler_so.remove('-Wstrict-prototypes')
         except (ValueError, AttributeError):
             pass
         for package in good_packages:
             package.do_custom_build()
-        return BuildExtCommand.run(self)
+        return super().build_extensions()
 
 
 cmdclass = versioneer.get_cmdclass()
