Do not hardcode fill=False in mark_inset

ImportanceOfBeingErnest · web-flow · commit fb49e1175136 · 2017-10-29T18:31:27.000+01:00
There should not be any reason to hardcode fill=False in `mark_inset`. This prevents having a filled Bbox_Patch. With the proposed change, something like `mark_inset(ax,axins,loc1=1,loc2=3, fill=True, edgecolor="k", facecolor="lightgrey")` will again be possible (it was in v1.3 but got broken at some point).
diff --git a/lib/mpl_toolkits/axes_grid1/inset_locator.py b/lib/mpl_toolkits/axes_grid1/inset_locator.py
@@ -578,8 +578,9 @@ def mark_inset(parent_axes, inset_axes, loc1, loc2, **kwargs):
         The patches connecting two corners of the inset axes and its area.
     """
     rect = TransformedBbox(inset_axes.viewLim, parent_axes.transData)
-
-    pp = BboxPatch(rect, fill=False, **kwargs)
+    
+    fill = kwargs.pop("fill", False)
+    pp = BboxPatch(rect, fill=fill, **kwargs)
     parent_axes.add_patch(pp)
 
     p1 = BboxConnector(inset_axes.bbox, rect, loc1=loc1, **kwargs)
