Added major/minor tick visibility params

bcongdon · bcongdon · commit fc7c02604ea9 · 2016-07-13T15:46:27.000-07:00
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -566,11 +566,26 @@ def __init__(self, fig, rect,
         if self.yaxis is not None:
             self._ycid = self.yaxis.callbacks.connect('units finalize',
                                                       self.relim)
-        self.tick_params(top=rcParams['xtick.top'],
-                         bottom=rcParams['xtick.bottom'],
-                         left=rcParams['ytick.left'],
-                         right=rcParams['ytick.right'],
-                         which='both')
+
+        self.tick_params(top=rcParams['xtick.top'] and
+                         rcParams['xtick.minor.top'],
+                         bottom=rcParams['xtick.bottom'] and
+                         rcParams['xtick.minor.bottom'],
+                         left=rcParams['ytick.left'] and
+                         rcParams['ytick.minor.left'],
+                         right=rcParams['ytick.right'] and
+                         rcParams['ytick.minor.right'],
+                         which='minor')
+
+        self.tick_params(top=rcParams['xtick.top'] and
+                         rcParams['xtick.major.top'],
+                         bottom=rcParams['xtick.bottom'] and
+                         rcParams['xtick.major.bottom'],
+                         left=rcParams['ytick.left'] and
+                         rcParams['ytick.major.left'],
+                         right=rcParams['ytick.right'] and
+                         rcParams['ytick.major.right'],
+                         which='major')
 
     def __setstate__(self, state):
         self.__dict__ = state
diff --git a/lib/matplotlib/rcsetup.py b/lib/matplotlib/rcsetup.py
@@ -1175,6 +1175,12 @@ def validate_animation_writer_path(p):
     'xtick.color':       ['k', validate_color],  # color of the xtick labels
     'xtick.minor.visible':   [False, validate_bool],    # visiablility of the x axis minor ticks
 
+    'xtick.minor.top':   [True, validate_bool],        # visability of the x axis top minor ticks
+    'xtick.minor.bottom':    [True, validate_bool],    # visability of the x axis bottom minor ticks
+    'xtick.major.top':   [True, validate_bool],        # visability of the x axis top major ticks
+    'xtick.major.bottom':    [True, validate_bool],    # visability of the x axis bottom major ticks
+
+
     # fontsize of the xtick labels
     'xtick.labelsize':   ['medium', validate_fontsize],
     'xtick.direction':   ['out', six.text_type],            # direction of xticks
@@ -1190,6 +1196,11 @@ def validate_animation_writer_path(p):
     'ytick.color':       ['k', validate_color],   # color of the ytick labels
     'ytick.minor.visible':   [False, validate_bool],    # visiablility of the y axis minor ticks
 
+    'ytick.minor.left':   [True, validate_bool],  # visability of the y axis top minor ticks
+    'ytick.minor.right':    [True, validate_bool],    # visability of the y axis bottom minor ticks
+    'ytick.major.left':   [True, validate_bool],        # visability of the y axis top major ticks
+    'ytick.major.right':    [True, validate_bool],    # visability of the y axis bottom major ticks
+
     # fontsize of the ytick labels
     'ytick.labelsize':   ['medium', validate_fontsize],
     'ytick.direction':   ['out', six.text_type],            # direction of yticks
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -4128,6 +4128,30 @@ def test_rc_tick():
         assert yax._minor_tick_kw['tick2On'] == False
 
 
+@cleanup
+def test_rc_major_minor_tick():
+    d = {'xtick.top': True, 'ytick.right': True,  # Enable all ticks
+         'xtick.bottom': True, 'ytick.left': True,
+         # Selectively disable
+         'xtick.minor.bottom': False, 'xtick.major.bottom': False,
+         'ytick.major.left': False, 'ytick.minor.left': False}
+    with plt.rc_context(rc=d):
+        fig = plt.figure()
+        ax1 = fig.add_subplot(1, 1, 1)
+        xax = ax1.xaxis
+        yax = ax1.yaxis
+        # tick1On bottom/left
+        assert xax._major_tick_kw['tick1On'] == False
+        assert xax._major_tick_kw['tick2On'] == True
+        assert xax._minor_tick_kw['tick1On'] == False
+        assert xax._minor_tick_kw['tick2On'] == True
+
+        assert yax._major_tick_kw['tick1On'] == False
+        assert yax._major_tick_kw['tick2On'] == True
+        assert yax._minor_tick_kw['tick1On'] == False
+        assert yax._minor_tick_kw['tick2On'] == True
+
+
 @cleanup
 def test_bar_negative_width():
     fig, ax = plt.subplots()
