Boilerplate.py review comments

ksunden · ksunden · commit fda8600e8ab9 · 2023-03-30T12:31:22.000-05:00
Bump autoformatted pyplot line width to 88 chars
diff --git a/lib/matplotlib/pyplot.py b/lib/matplotlib/pyplot.py
@@ -2393,7 +2393,9 @@ def figimage(X: ArrayLike, xo: int = 0, yo: int = 0, alpha: float | None = None,
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
 @_copy_docstring_and_deprecators(Figure.text)
-def figtext(x: float, y: float, s: str, fontdict: dict[str, Any] | None = None, **kwargs) -> Text:
+def figtext(
+    x: float, y: float, s: str, fontdict: dict[str, Any] | None = None, **kwargs
+) -> Text:
     return gcf().text(x, y, s, fontdict=fontdict, **kwargs)
 
 
@@ -2422,8 +2424,8 @@ def ginput(n: int = 1, timeout: float = 30, show_clicks: bool = True, mouse_add:
 @_copy_docstring_and_deprecators(Figure.subplots_adjust)
 def subplots_adjust(left: str | None = None, bottom: str | None = None, right: str | None = None, top: str | None = None, wspace: str | None = None, hspace: str | None = None) -> None:
     return gcf().subplots_adjust(
-        left=left, bottom=bottom, right=right, top=top, wspace=wspace,
-        hspace=hspace)
+        left=left, bottom=bottom, right=right, top=top, wspace=wspace, hspace=hspace
+    )
 
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
@@ -2446,9 +2448,10 @@ def waitforbuttonpress(timeout: float = -1):
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
 @_copy_docstring_and_deprecators(Axes.acorr)
-def acorr(x: ArrayLike, *, data=None, **kwargs) -> tuple[np.ndarray, np.ndarray, LineCollection | Line2D, Line2D | None]:
-    return gca().acorr(
-        x, **({"data": data} if data is not None else {}), **kwargs)
+def acorr(
+    x: ArrayLike, *, data=None, **kwargs
+) -> tuple[np.ndarray, np.ndarray, LineCollection | Line2D, Line2D | None]:
+    return gca().acorr(x, **({"data": data} if data is not None else {}), **kwargs)
 
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
@@ -2527,9 +2530,7 @@ def bar(x: float | ArrayLike, height: float | ArrayLike, width: float | ArrayLik
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
 @_copy_docstring_and_deprecators(Axes.barbs)
 def barbs(*args, data=None, **kwargs) -> Barbs:
-    return gca().barbs(
-        *args, **({"data": data} if data is not None else {}),
-        **kwargs)
+    return gca().barbs(*args, **({"data": data} if data is not None else {}), **kwargs)
 
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
@@ -2569,8 +2570,8 @@ def boxplot(x: ArrayLike | Sequence[ArrayLike], notch: bool | None = None, sym:
 @_copy_docstring_and_deprecators(Axes.broken_barh)
 def broken_barh(xranges: Sequence[tuple[float, float]], yrange: tuple[float, float], *, data=None, **kwargs) -> BrokenBarHCollection:
     return gca().broken_barh(
-        xranges, yrange,
-        **({"data": data} if data is not None else {}), **kwargs)
+        xranges, yrange, **({"data": data} if data is not None else {}), **kwargs
+    )
 
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
@@ -2654,9 +2655,7 @@ def eventplot(positions: ArrayLike | Sequence[ArrayLike], orientation: Literal['
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
 @_copy_docstring_and_deprecators(Axes.fill)
 def fill(*args, data: Any | None = None, **kwargs) -> list[Polygon]:
-    return gca().fill(
-        *args, **({"data": data} if data is not None else {}),
-        **kwargs)
+    return gca().fill(*args, **({"data": data} if data is not None else {}), **kwargs)
 
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
@@ -2717,7 +2716,19 @@ def stairs(values: ArrayLike, edges: ArrayLike | None = None, *, orientation: Li
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
 @_copy_docstring_and_deprecators(Axes.hist2d)
-def hist2d(x: ArrayLike, y: ArrayLike, bins: None | int | tuple[int, int] | ArrayLike | tuple[ArrayLike, ArrayLike] = 10, range: ArrayLike | None = None, density: bool = False, weights: ArrayLike | None = None, cmin: float | None = None, cmax: float | None = None, *, data=None, **kwargs) -> tuple[np.ndarray, np.ndarray, np.ndarray, QuadMesh]:
+def hist2d(
+    x: ArrayLike,
+    y: ArrayLike,
+    bins: None | int | tuple[int, int] | ArrayLike | tuple[ArrayLike, ArrayLike] = 10,
+    range: ArrayLike | None = None,
+    density: bool = False,
+    weights: ArrayLike | None = None,
+    cmin: float | None = None,
+    cmax: float | None = None,
+    *,
+    data=None,
+    **kwargs,
+) -> tuple[np.ndarray, np.ndarray, np.ndarray, QuadMesh]:
     __ret = gca().hist2d(
         x, y, bins=bins, range=range, density=density,
         weights=weights, cmin=cmin, cmax=cmax,
@@ -2758,7 +2769,9 @@ def legend(*args, **kwargs) -> Legend:
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
 @_copy_docstring_and_deprecators(Axes.locator_params)
-def locator_params(axis: Literal['both', 'x', 'y'] = 'both', tight: bool | None = None, **kwargs) -> None:
+def locator_params(
+    axis: Literal["both", "x", "y"] = "both", tight: bool | None = None, **kwargs
+) -> None:
     return gca().locator_params(axis=axis, tight=tight, **kwargs)
 
 
@@ -2916,7 +2929,24 @@ def quiverkey(Q: Quiver, X: float, Y: float, U: float, label: str, **kwargs) ->
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
 @_copy_docstring_and_deprecators(Axes.scatter)
-def scatter(x: float | ArrayLike, y: float | ArrayLike, s: float | ArrayLike | None = None, c: Sequence[Color] | Color | None = None, marker: MarkerType | None = None, cmap: str | Colormap | None = None, norm: str | Normalize | None = None, vmin: float | None = None, vmax: float | None = None, alpha: float | None = None, linewidths: float | Sequence[float] | None = None, *, edgecolors: Literal['face', 'none'] | Color | Sequence[Color] | None = None, plotnonfinite: bool = False, data=None, **kwargs) -> PathCollection:
+def scatter(
+    x: float | ArrayLike,
+    y: float | ArrayLike,
+    s: float | ArrayLike | None = None,
+    c: Sequence[Color] | Color | None = None,
+    marker: MarkerType | None = None,
+    cmap: str | Colormap | None = None,
+    norm: str | Normalize | None = None,
+    vmin: float | None = None,
+    vmax: float | None = None,
+    alpha: float | None = None,
+    linewidths: float | Sequence[float] | None = None,
+    *,
+    edgecolors: Literal["face", "none"] | Color | Sequence[Color] | None = None,
+    plotnonfinite: bool = False,
+    data=None,
+    **kwargs,
+) -> PathCollection:
     __ret = gca().scatter(
         x, y, s=s, c=c, marker=marker, cmap=cmap, norm=norm,
         vmin=vmin, vmax=vmax, alpha=alpha, linewidths=linewidths,
@@ -2940,7 +2970,29 @@ def semilogy(*args, **kwargs) -> list[Line2D]:
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
 @_copy_docstring_and_deprecators(Axes.specgram)
-def specgram(x: ArrayLike, NFFT: int | None = None, Fs: float | None = None, Fc: int | None = None, detrend: Literal['none', 'mean', 'linear'] | Callable[[ArrayLike], ArrayLike] | None = None, window: Callable[[ArrayLike], ArrayLike] | ArrayLike | None = None, noverlap: int | None = None, cmap: str | Colormap | None = None, xextent: tuple[float, float] | None = None, pad_to: int | None = None, sides: Literal['default', 'onesided', 'twosided'] | None = None, scale_by_freq: bool | None = None, mode: Literal['default', 'psd', 'magnitude', 'angle', 'phase'] | None = None, scale: Literal['default', 'linear', 'dB'] | None = None, vmin: float | None = None, vmax: float | None = None, *, data=None, **kwargs) -> tuple[np.ndarray, np.ndarray, np.ndarray, AxesImage]:
+def specgram(
+    x: ArrayLike,
+    NFFT: int | None = None,
+    Fs: float | None = None,
+    Fc: int | None = None,
+    detrend: Literal["none", "mean", "linear"]
+    | Callable[[ArrayLike], ArrayLike]
+    | None = None,
+    window: Callable[[ArrayLike], ArrayLike] | ArrayLike | None = None,
+    noverlap: int | None = None,
+    cmap: str | Colormap | None = None,
+    xextent: tuple[float, float] | None = None,
+    pad_to: int | None = None,
+    sides: Literal["default", "onesided", "twosided"] | None = None,
+    scale_by_freq: bool | None = None,
+    mode: Literal["default", "psd", "magnitude", "angle", "phase"] | None = None,
+    scale: Literal["default", "linear", "dB"] | None = None,
+    vmin: float | None = None,
+    vmax: float | None = None,
+    *,
+    data=None,
+    **kwargs,
+) -> tuple[np.ndarray, np.ndarray, np.ndarray, AxesImage]:
     __ret = gca().specgram(
         x, NFFT=NFFT, Fs=Fs, Fc=Fc, detrend=detrend, window=window,
         noverlap=noverlap, cmap=cmap, xextent=xextent, pad_to=pad_to,
@@ -2963,7 +3015,7 @@ def spy(Z: ArrayLike, precision: float | Literal['present'] = 0, marker: str | N
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
 @_copy_docstring_and_deprecators(Axes.stackplot)
-def stackplot(x, *args, labels=(), colors=None, baseline='zero', data=None, **kwargs):
+def stackplot(x, *args, labels=(), colors=None, baseline="zero", data=None, **kwargs):
     return gca().stackplot(
         x, *args, labels=labels, colors=colors, baseline=baseline,
         **({"data": data} if data is not None else {}), **kwargs)
@@ -3015,7 +3067,9 @@ def table(cellText=None, cellColours=None, cellLoc='right', colWidths=None, rowL
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
 @_copy_docstring_and_deprecators(Axes.text)
-def text(x: float, y: float, s: str, fontdict: dict[str, Any] | None = None, **kwargs) -> Text:
+def text(
+    x: float, y: float, s: str, fontdict: dict[str, Any] | None = None, **kwargs
+) -> Text:
     return gca().text(x, y, s, fontdict=fontdict, **kwargs)
 
 
@@ -3103,9 +3157,16 @@ def sci(im: ScalarMappable) -> None:
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
 @_copy_docstring_and_deprecators(Axes.set_title)
-def title(label: str, fontdict: dict[str, Any] | None = None, loc: Literal['left', 'center', 'right'] | None = None, pad: float | None = None, *, y: float | None = None, **kwargs) -> Text:
-    return gca().set_title(
-        label, fontdict=fontdict, loc=loc, pad=pad, y=y, **kwargs)
+def title(
+    label: str,
+    fontdict: dict[str, Any] | None = None,
+    loc: Literal["left", "center", "right"] | None = None,
+    pad: float | None = None,
+    *,
+    y: float | None = None,
+    **kwargs,
+) -> Text:
+    return gca().set_title(label, fontdict=fontdict, loc=loc, pad=pad, y=y, **kwargs)
 
 
 # Autogenerated by boilerplate.py.  Do not edit as changes will be lost.
diff --git a/tools/boilerplate.py b/tools/boilerplate.py
@@ -15,6 +15,7 @@
 
 import ast
 from enum import Enum
+import functools
 import inspect
 from inspect import Parameter
 from pathlib import Path
@@ -385,7 +386,7 @@ def build_pyplot(pyplot_path):
 
     # Run black to autoformat pyplot
     subprocess.run(
-        [sys.executable, "-m", "black", "--line-length=79", pyplot_path]
+        [sys.executable, "-m", "black", "--line-length=88", pyplot_path]
     )
 
 
@@ -399,9 +400,10 @@ def get_ast_tree(cls):
     for item in tree.body:
         if isinstance(item, ast.ClassDef) and item.name == cls.__name__:
             return item
-    raise ValueError("Cannot find {cls.__name__} in ast")
+    raise ValueError(f"Cannot find {cls.__name__} in ast")
 
 
+@functools.lru_cache
 def get_ast_mro_trees(cls):
     return [get_ast_tree(c) for c in cls.__mro__ if c.__module__ != "builtins"]
 
@@ -433,11 +435,11 @@ def update_sig_from_node(node, sig):
     params = dict(sig.parameters)
     args = node.args
     allargs = (
-        args.posonlyargs
-        + args.args
-        + [args.vararg]
-        + args.kwonlyargs
-        + [args.kwarg]
+        *args.posonlyargs,
+        *args.args,
+        args.vararg,
+        *args.kwonlyargs,
+        args.kwarg,
     )
     for param in allargs:
         if param is None:
