Merge pull request #563 from mdboom/issue563

WeatherGod · WeatherGod · commit ff4bb1efe783 · 2012-08-21T06:22:21.000-07:00
sankey.add() has mutable defaults
diff --git a/lib/matplotlib/sankey.py b/lib/matplotlib/sankey.py
@@ -245,9 +245,9 @@ def _revert(self, path, first_action=Path.LINETO):
         #return path
 
     @docstring.dedent_interpd
-    def add(self, patchlabel='', flows=np.array([1.0, -1.0]),
-            orientations=[0, 0], labels='', trunklength=1.0, pathlengths=0.25,
-            prior=None, connect=(0, 0), rotation=0, **kwargs):
+    def add(self, patchlabel='', flows=None, orientations=None, labels='',
+            trunklength=1.0, pathlengths=0.25, prior=None, connect=(0, 0),
+            rotation=0, **kwargs):
         """
         Add a simple Sankey diagram with flows at the same hierarchical level.
 
@@ -328,13 +328,18 @@ def add(self, patchlabel='', flows=np.array([1.0, -1.0]),
             :meth:`finish`
         """
         # Check and preprocess the arguments.
-        flows = np.array(flows)
+        if flows is None:
+            flows = np.array([1.0, -1.0])
+        else:
+            flows = np.array(flows)
         n = flows.shape[0]  # Number of flows
         if rotation == None:
             rotation = 0
         else:
             # In the code below, angles are expressed in deg/90
             rotation /= 90.0
+        if orientations is None:
+            orientations = [0, 0]
         assert len(orientations) == n, (
             "orientations and flows must have the same length.\n"
             "orientations has length %d, but flows has length %d."
