-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Make kiwisolver an optional dependency? #10386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is |
On my machine at least it doesn't seem to come pre-compiled so builds it from a source distribution, which takes ~30 secs. It's not a massive issue, but keeping the install simple with minimum dependencies would be nice. |
@tacaswell and @QuLogic discussed on gitter, and should be the final arbitrers. I have no idea how onerous this dependency is in the general install world, but it would be a shame from a usability point of view if it wasn't installed by default. e.g. its a lot easier to tell a user to try |
Looks like @matthew-brett is trying to get OSX wheels built for that? (nucleic/kiwi#44) |
@jklymak it's also required for the tests...which are there own odd install set. |
@anntzer - yes I'm using multibuild which builds both OSX and manyinux wheels, as well as Windows wheels: https://github.com/MacPython/kiwisolver-wheels The sticking point is the issue you've pointed to. |
what's wrong with running pytest from their source folder? (yes, you may prefer being sure not to be accidentally importing something from the source tree, but it's a C-only package with no python component so indeed you won't be importing anything from the source tree (other than the tests)) |
I am running pytest from the source folder! |
I meant the kiwi tests (the issue mentioned by @matthew-brett in the kiwi repo). |
@anntzer - yes, that's not a bad idea in our case (where we do have the source repo to hand) - I'll give it a go. |
kiwisolver is in Fedora now. |
Thanks a lot @QuLogic |
The Kiwisolver maintainer @MatthieuDartiailh has kindly put up wheels now: https://pypi.org/project/kiwisolver/#files @MatthieuDartiailh - I guess you're planning to keep updating these for new releases? I'm asking because it may well affect whether Matplotlib takes Kiwisolver as a dependency. |
Yes I will keep updating those. Even though I have no short term plans for updates to this library. However should any bugs be found, I will try to address those and release in consequence. |
I'm happy leaving this as a dependency in that case - thanks a lot @MatthieuDartiailh for making the wheels! |
You should rather thank @matthew-brett for setting up the whole infrastructure. Even the upload of the wheels is automated. |
FWIW kiwisolver takes a non-trivial amount of time (maybe 5 minutes) to compile & install on my power- and resource- constrained raspberry Pi. |
I believe there are wheels, for Python 3.5 : https://www.piwheels.hostedpi.com/simple/kiwisolver/ |
#9082 introduced a nice new geometry manager, but now installing Matplotlib requires installing kiwisolver. Would it be possible to make this an optional dependency that is only needed for doing constrained layout stuff (especially since the layout stuff is experimental at the moment)?
The text was updated successfully, but these errors were encountered: