Thanks to visit codestin.com
Credit goes to github.com

Skip to content

broken link in lib/matplotlib/dates.py comment #10453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pseyfert opened this issue Feb 14, 2018 · 3 comments · Fixed by #10461
Closed

broken link in lib/matplotlib/dates.py comment #10453

pseyfert opened this issue Feb 14, 2018 · 3 comments · Fixed by #10461
Milestone
v2.2.1

Comments

@pseyfert
Copy link
Contributor

Bug report

Not really a bug in terms of misbehaving code. I was just trying to understand lib/matplotlib/dates.py and and found a link in a comment that lead nowhere.

268ca34#diff-e6ad13bbdbf1912ae565e5ed7f274144R515

https://bugs.python.org/issue177742

The code just says

if dt.year >= 1900:
    # Note: in python 3.3 this is okay for years >= 1000,
    # refer to http://bugs.python.org/issue177742
    return cbook.unicode_safe(dt.strftime(fmt))

Expected outcome

The link leads to an existing bug which can then be read.

Matplotlib version

Cloned the current master, e.g. 86514a2, but also in matplotlib 2.0.0
@jenshnielsen
Copy link
Member

I would guess that the correct issue is https://bugs.python.org/issue1777412

@pseyfert
Copy link
Contributor Author

Thanks, that looks correct indeed.

(I realised now I could've found that #3242 (comment) in the discussion of the merge request that added the comment).

Should I make a tiny PR that adds the missing digit?

pseyfert added a commit to pseyfert/matplotlib that referenced this issue Feb 14, 2018
@pseyfert
fix broken link in lib/matplotlib/dates.py comment
9c475c6 
This closes matplotlib#10453
@tacaswell
Copy link
Member

@pseyfert Yes please!

@tacaswell tacaswell added this to the v2.2.1 milestone Feb 14, 2018
@pseyfert pseyfert mentioned this issue Feb 14, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.1
Development

Successfully merging a pull request may close this issue.

fix broken link in lib/matplotlib/dates.py comment pseyfert/matplotlib
3 participants
@tacaswell @jenshnielsen @pseyfert