Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Undefined names: 'obj_type' and 'cbook' #11550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cclauss opened this issue Jul 2, 2018 · 1 comment
Closed

Undefined names: 'obj_type' and 'cbook' #11550

cclauss opened this issue Jul 2, 2018 · 1 comment
Milestone
v3.0.0

Comments

@cclauss
Copy link

cclauss commented Jul 2, 2018

@anntzer I thought we had testing in place to catch these kind of errors before PR review.

flake8 testing of https://github.com/matplotlib/matplotlib on Python 3.6.3

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./lib/matplotlib/__init__.py:917:31: F821 undefined name 'obj_type'
                version, key, obj_type, alternative=alt_key)
                              ^
./lib/matplotlib/gridspec.py:279:13: F821 undefined name 'cbook'
            cbook.warn_deprecated("2.2", "fig", obj_type="keyword argument",
            ^
./lib/matplotlib/gridspec.py:369:13: F821 undefined name 'cbook'
            cbook.warn_deprecated("2.2", "fig", obj_type="keyword argument",
            ^
3     F821 undefined name 'obj_type'
3
@anntzer
Copy link
Contributor

anntzer commented Jul 2, 2018

Well, I'm waiting for #11477 (comment) to be resolved...

QuLogic added a commit to QuLogic/matplotlib that referenced this issue Jul 7, 2018
@QuLogic
Fix undefined names.
200c18f 
Fixes matplotlib#11550.
@cclauss cclauss mentioned this issue Jul 8, 2018
Merged
1 task
@QuLogic QuLogic added this to the v3.0 milestone Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
3 participants
@QuLogic @anntzer @cclauss