Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug in tight_layout #11737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fredrik-1 opened this issue Jul 22, 2018 · 3 comments · Fixed by #11754
Closed

Bug in tight_layout #11737

fredrik-1 opened this issue Jul 22, 2018 · 3 comments · Fixed by #11754
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Milestone
v3.0.0

Comments

@fredrik-1
Copy link
Contributor

I just found a critical bug in tight_layout in master (unless something is wrong with my installation...).

fig, ax=plt.subplots()
fig.set_tight_layout(True)
plt.show()

The axes get into a black hole in the middle of the figure if I try to zoom.

master
python 3.5, 3.6
windows 10
@fredrik-1
Copy link
Contributor Author

It seems that the new tests for correct subplotparams in tight_layoutfor some reason don't work in the use case above. I am looking into it.

@fredrik-1
Copy link
Contributor Author

Some more information. The left, right etc values in the tight_layout module became incorrect. Those values get send to Subplotparams.update where they are silently changed to the old values. The raise ValueError is not working, probably due to a try somewhere.

So zooming seems to work without the new tests in the tight_layout module but it actually doesn't because the old suplotparameters are just used once again.

@fredrik-1 fredrik-1 mentioned this issue Jul 22, 2018
Closed
6 tasks
@fredrik-1
Copy link
Contributor Author

#11739 might fix the bug.

@jklymak jklymak mentioned this issue Jul 23, 2018
Closed
6 tasks
@jklymak jklymak added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jul 23, 2018
@jklymak jklymak added this to the v3.0 milestone Jul 23, 2018
@jklymak jklymak mentioned this issue Jul 23, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
2 participants
@jklymak @fredrik-1