-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Still naming inconsistency in API on axes limits #11761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, [note: this is almost a copy of my initial message in #11293, but, as @jklymak suggested, this issue is the one open at present] It's only pretty recently that I discovered the deprecation of xmin, xmax arguments since I'm working with stable releases of Matlplotlib and I only " So I got rather frustrated by the deprecation, and thus I dig in the PRs. What I read didn't convinced me:
So my conclusion is that the "consequence analysis" (sorry, I don't have the proper word for this) for this deprecation was a bit short and I'm not sure the aesthetical reason (the duplicate keywords which I agree is odd) is worth breaking piles of existing codes (assuming I'm not the only weird addict user of xmin, xmax, ymin, ymax ;-) ). Am I indeed lonely? |
Tagging as release critical. Are we really still sure that deprecating xmin, xmax etc. is a good idea (I'm not). |
Discussed this on the phone call and decided that we should revert the deprecation of the xmin/xmax and ymin/ymax kwargs. |
I still think un-deprecating these is the right path, but I would stress that before #11137 these kwargs were undocumented! That definitely contributed to short discussion "these are not documented, so we expect no one to be using them, but let's do a deprecation cycle just to be safe" is not an un-reasonable position to take. @pierre-haessig Thanks for digging into this! See #13425 |
Fixed by #13425 |
Uh oh!
There was an error while loading. Please reload this page.
Bug report
#11137 deprecated the kwargs
*min/*max
ofset_*lim
(after some disussion there and in #11293).Axes.axis uses the
*min
,*max
parameter names as well. Currently, this does not supportleft, right, bottom, top
at all.This is an inconsistency within the current API, and if we're serious with the change
Axes.axis()
whould have to be changes as well.The text was updated successfully, but these errors were encountered: