Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do we need input hooks macosx? #12632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jklymak opened this issue Oct 25, 2018 · 1 comment
Closed

Do we need input hooks macosx? #12632

jklymak opened this issue Oct 25, 2018 · 1 comment

Comments

@jklymak
Copy link
Member

jklymak commented Oct 25, 2018 •
edited
Loading

Following up from #12629 there are some mysterious input hook calls in _macosx that we aren[t sure if they are necessary anymore...

Originally posted by @mattip in #12629 (comment)

My guess is they were needed at one point to allow the tkinter event loop and the REPL event loop to play nicely. But then why were they MacOS only, unless at one point python vendored a broken version of tk on that platform?

Maybe someone with the oldest python and MacOS matplotlib supports could verify the terminal and the canvas are both responsive after removing the callback
@jklymak jklymak changed the title My guess is they were needed at one point to allow the tkinter event loop and the REPL event loop to play nicely. But then why were they MacOS only, unless at one point python vendored a broken version of tk on that platform? Do we need input hooks macosx? Oct 25, 2018
@jklymak
Copy link
Member Author

jklymak commented Oct 25, 2018

Yeah we do - if I remove those lines, I can't close the figure window from the GUI...

@jklymak jklymak closed this as completed Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jklymak