Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Secondary axis doesn't resize properly #13417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jklymak opened this issue Feb 12, 2019 · 3 comments · Fixed by #13419
Closed

Secondary axis doesn't resize properly #13417

jklymak opened this issue Feb 12, 2019 · 3 comments · Fixed by #13419
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Milestone

Comments

@jklymak
Copy link
Member

jklymak commented Feb 12, 2019

From @ImportanceOfBeingErnest

I just ran the first example from this PR and the result looks like this on screen:

image

If resizing the figure window with the mouse this can become as bad as

image

The saved figure is fine though.
(This is with master fetched a few minutes ago, python 3.6.6 on windows 8.1, Qt5Agg)

Let me know if you need further details or want me to test anything particular with my configuration.

Originally posted by @ImportanceOfBeingErnest in #11859 (comment)

@jklymak
Copy link
Member Author

jklymak commented Feb 12, 2019

Confirmed for window resize. Obviously the first draw isn't bad for me. Hopefully this is easy to fix

@efiring efiring added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Feb 12, 2019
@efiring efiring added this to the v3.1.0 milestone Feb 12, 2019
@jklymak
Copy link
Member Author

jklymak commented Feb 12, 2019

cross ref #11859 (the original PR)

@jklymak
Copy link
Member Author

jklymak commented Feb 12, 2019

Thanks @ImportanceOfBeingErnest - fix was easy-ish. The axes locator has to be evaluated at draw time, and not compute too much ahead of time. The code was changed at a later date, and I should have rechecked resize...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants