Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Path collection filling/stroking logic is different from the usual in the pdf backend #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jkseppan opened this issue Oct 18, 2012 · 3 comments
Closed

Path collection filling/stroking logic is different from the usual in the pdf backend #1412

jkseppan opened this issue Oct 18, 2012 · 3 comments
Assignees
@dmcdougall

Comments

@jkseppan
Copy link
Member

Reported in: http://permalink.gmane.org/gmane.comp.python.matplotlib.general/32019

In the pdf backend, draw_path_collection contains

    filled = len(facecolors)
    stroked = len(edgecolors)

so it fills if any fill color is specified, and strokes if any stroke color is specified. This is not the same logic as for other objects. Specifically, a linewidth of zero should cause the paths not to be stroked (because in pdf, a zero-width line is a line of some device-specific minimum width, whereas in agg a zero-width line is a line not drawn).

I think the code needs to make the filled/stroked decisions when creating the XObjects, so the current _iter_collection_raw_paths method is not quite sufficient.
@mdboom
Copy link
Member

mdboom commented Apr 12, 2013

I think #1860 fixes a lot of this. Do you agree? If so, maybe we should close this.

@jkseppan
Copy link
Member Author

Yes, #1860 looks like essentially the same issue. Does it fix the specific problem with line width zero? (I can't test myself right now.)

Michael Droettboom [email protected] wrote:

I think #1860 fixes a lot of this. Do you agree? If so, maybe we should close this.

—
Reply to this email directly or view it on GitHub.

@ghost ghost assigned dmcdougall Jun 16, 2013
@tacaswell
Copy link
Member

Closing this as we have at least one other issue related to special casing zero-width lines in pdfs (#2910), it sounds like the bulk of this is already fixed, and this is over a year old.

@jkseppan Please re-open if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmcdougall dmcdougall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mdboom @jkseppan @tacaswell @dmcdougall