Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Should set_pickradius() implicitly call set_picker(True)? #19039

Open
@anntzer

Description

@anntzer

Describe the issue

In #16154/#19026 I am deprecating implicitly setting the pickradius of an Artist via set_picker(<number>), because this causes various arising from the fact that True == 1 and False == 0 (listed in the discussions of the issues above). I am still convinced that this change is for the better. However, now there are a few places where calls to set_picker(<number>) (usually implicit though kwargs, e.g. plot(..., picker=<number>)) now need to be replaced by set(picker=True, pickradius=<number>), which is perhaps unnecessarily verbose (I'd guess the vast majority of people setting the pickradius indeed want to turn on picking). So we could consider making set_pickradius() also implicitly call set_picker(True), or perhaps even internally differentiate picker = <unset> (i.e., False, but gets turned on by set_pickradius) and picker = None (i.e. disabled). Or we could just decide that this whole deprecation was not worth it and go back to overloading picker to support pickradius values.

Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions