-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Switch to pydata-sphinx-theme #19423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If its responsive, then 👍 👍 👍 I do prefer our color scheme to the numpy one, which seems a bit bare-bones. But I won't complain... |
I like what the bokeh site is doing & think that might be a good inspiration for incorporating mpl.colors. https://docs.bokeh.org/en/dev/ I'm definitely +1 on something phone friendly |
@timhoffm I want to work on this issue. I would like to sort the disentangling of current mpl.css while someone else can do the customization of conf.py in collaboration or if you guide me I can even do it |
I would guess they have to be done together? Eat bet is to just give it a try and see what breaks. I wouldn't spend a lot of time polishing it until there is consensus that it's a good idea. So even if it is 75% good that would really help us know what's involved. |
I can do it but I would need some guidance on it @jklymak |
Follow the instructions, build the website and see what it looks like? Beyond that, I'd have to figure it out just like you would. |
sureee |
@jklymak well I edited the conf.py how to view the website ? |
Please read https://matplotlib.org/devdocs/devel/documenting_mpl.html I'd make sure you can build the website as-is before I changed |
I have started to take a pass at this, will try to push what I have gotten done later tonight. It breaks a lot of things :) |
#19731 @rajpratyush Can you get the branch in that PR to build locally? |
@tacaswell I have got the dependencies and set up the dev environment but i don't have a latex system yet. no I don't have access to the branch locally if you provide me access to this branch, then only I can and then I can go through it and edit the css file which is causing the site to break it. |
Current status:
Proposal:
Reuse https://github.com/pydata/pydata-sphinx-theme, which has been adopted by some major numfocus projects.
I anticipate less maintainance effort on our side, because the theme is shared between multiple major projects.
I like the idea that major numfocus projects have similar but still distinct designs. One should recognize that numpy and matplotlib are related, but I still want to immediately see if I'm on numpy, pandas or matplotlib docs.
This needs som customization in terms of fonts, color, etc., Ideally make these things configurable options upstream in pydata-sphinx-theme so that we can just set it in
conf.py
and the theme does the rest.This will also need some disentangling of the current
mpl.css
for keeping parts we still need in a same or similar form (e.g. gallery layout, version box, ...).The text was updated successfully, but these errors were encountered: