Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve 'Writing ReST Pages' section on docs #20522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aitikgupta opened this issue Jun 25, 2021 · 4 comments · Fixed by #20535
Closed

Improve 'Writing ReST Pages' section on docs #20522

aitikgupta opened this issue Jun 25, 2021 · 4 comments · Fixed by #20535
Milestone

Comments

@aitikgupta
Copy link
Contributor

aitikgupta commented Jun 25, 2021

Suggested Improvement

The documentation on reStructuredText: https://matplotlib.org/stable/devel/documenting_mpl.html#writing-rest-pages lacks some very common formatting like specifying the heading types (which is arbitrary in general, but might be worth putting down in docs for consistency throughout the documentation while writing/modifying one), links, etc.

The reST documentation links to: https://docutils.sourceforge.io/rst.html#reference-documentation, but it might also be worth pointing to a Sphinx side of it: https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html (which seems a bit easier to read and navigate for someone new to writing docs).

I also didn't find anything which allows a user to directly open the generated docs: make show. (even though it generates local HTML files, it might be worth adding this command to docs as well).

Matplotlib version

  • Operating system:
  • Matplotlib version (import matplotlib; print(matplotlib.__version__)):
  • Matplotlib documentation version (is listed under the logo):
@timhoffm
Copy link
Member

timhoffm commented Jun 27, 2021

Most of above should be addressed by #20534 #20535.

I've opened a separate dedicated issue #20534 for the headings, which we explicitly have to document because there is no universal convention.

In "Writing ReST pages" we should only document formatting that is specific to Matplotlib. General "very common formatting" is covered by the links to Sphinx and docutils, we should not repeat that. AFAICS all other specific topics are already covered in "Writing ReST pages". But you are welcome to propose additional content that we may have overlooked.

@aitikgupta
Copy link
Contributor Author

General "very common formatting" is covered by the links to Sphinx and docutils, we should not repeat that.

Yeah, I just added that we can also add a link to Sphinx side of the documentation.

all other specific topics are already covered in "Writing ReST pages"

I think the docs still miss a written guide/sample which allows a user to directly open the generated docs: make show.
(even though it generates local HTML files, @tacaswell pointed out in one of the gitter messages about this command:
"there is make show which will open it but also doc/build/html",
and putting it in docs might be easier for somebody writing documentation?)

In general, this issue's first paragraph I think would well enough be handled by #20534, the second and third paragraph still need to be addressed. (if I correctly read @timhoffm's comment that is 😅)

@timhoffm
Copy link
Member

Sorry, I mixed up the ticket numbers. Please read my comment above again, which now links correctly to the respectively mentioned content.

@aitikgupta
Copy link
Contributor Author

Sorry, I mixed up the ticket numbers.

Ah, no problem. I think the merged PR solves this issue entirely (except headings, for which we have a new issue).
Closing 👍🏼

@QuLogic QuLogic modified the milestones: v3.4.3, v3.5.0 Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants