Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Bug]: macOS: PyPy 3.8 (v7.3.9) threading get_native_id Broken #24094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ax3l opened this issue Oct 5, 2022 · 3 comments · Fixed by #24178
Closed

[Bug]: macOS: PyPy 3.8 (v7.3.9) threading get_native_id Broken #24094

ax3l opened this issue Oct 5, 2022 · 3 comments · Fixed by #24178
Milestone
v3.6.2

Comments

@ax3l
Copy link

ax3l commented Oct 5, 2022

Bug summary

In PyPy 3.8 (v7.3.9), matplotlib 3.6.0 is cannot be imported, leading to breakage.

Ref.: https://foss.heptapod.net/pypy/pypy/-/issues/3764

Code for reproduction

import matplotlib.pyplot as plt

Actual outcome

AttributeError: module 'threading' has no attribute 'get_native_id'

in matplotlib/pyplot.py:337

     def _warn_if_gui_out_of_main_thread():
         # This compares native thread ids because even if python-level Thread
         # objects match, the underlying OS thread (which is what really matters)
         # may be different on Python implementations with green threads.
         if (_get_required_interactive_framework(_get_backend_mod()) and
 >               threading.get_native_id() != threading.main_thread().native_id):
 E               AttributeError: module 'threading' has no attribute 'get_native_id'

Expected outcome

Work as usual.

Additional information

This has been first posted in PyPy: https://foss.heptapod.net/pypy/pypy/-/issues/3764

I saw this on Conda-Forge, starting a few weeks ago as they shipped the latest PyPy 3.8.

Operating system

macOS 11.7 (x86_64) via Azure Pipelines 14 Runner

Matplotlib Version

3.6.0

Matplotlib Backend

default

Python version

PyPy 3.8 (v7.3.9)

Jupyter version

N/A

Installation

conda
@ax3l ax3l mentioned this issue Oct 5, 2022
Closed
@QuLogic QuLogic added this to the v3.6.2 milestone Oct 12, 2022
@QuLogic
Copy link
Member

QuLogic commented Oct 14, 2022

@anntzer should we just fall back to the previous thread ID implementation when get_native_id is unavailable?

@anntzer
Copy link
Contributor

anntzer commented Oct 14, 2022 •
edited
Loading

I would guess that's better than nothing? This was added in #23445 to better support green threads, which may not really be a problem with pypy anyways? (I don't know if such threading libraries exist for pypy...)

QuLogic added a commit to QuLogic/matplotlib that referenced this issue Oct 15, 2022
@QuLogic
Fall back to Python-level Thread for GUI warning
d4cf0f7 
This is mainly for the benefit of PyPy.

Fixes matplotlib#24094
@QuLogic QuLogic mentioned this issue Oct 15, 2022
Merged
1 task
@ax3l
Copy link
Author

ax3l commented Oct 15, 2022

Thank you all for the fix! 🎉

chahak13 pushed a commit to chahak13/matplotlib that referenced this issue Oct 18, 2022
@QuLogic @chahak13
Fall back to Python-level Thread for GUI warning
b1d8575 
This is mainly for the benefit of PyPy.

Fixes matplotlib#24094
pratimugale pushed a commit to pratimugale/matplotlib that referenced this issue Oct 24, 2022
@QuLogic @pratimugale
Fall back to Python-level Thread for GUI warning
5e133e1 
This is mainly for the benefit of PyPy.

Fixes matplotlib#24094
@akrherz akrherz mentioned this issue Oct 28, 2022
Merged
5 tasks
melissawm pushed a commit to melissawm/matplotlib that referenced this issue Dec 19, 2022
@QuLogic @melissawm
Fall back to Python-level Thread for GUI warning
8811962 
This is mainly for the benefit of PyPy.

Fixes matplotlib#24094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.2
Development

Successfully merging a pull request may close this issue.

Fall back to Python-level Thread for GUI warning QuLogic/matplotlib
3 participants
@QuLogic @anntzer @ax3l