-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[Doc]: windows install instructions do not work #24779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
These were issues I observed people having at the pydata global sprints, 🐑 it took me this long to write them up. |
Is that pikepdf/pikepdf#410? I haven't tested, but it seems there are wheels available since a couple of days. - Some problems solve themselves if you wait long enough 😄 Other We may consider having an infrequent CI run that builds based on |
I do not remember what version of Python they reported using.... |
There are wheels on pypi but not on conda/conda-forge. |
I don't have a windows box to try, but perhaps using |
Thinking twice, pikepdf is installed from pip, so it was probably just that there were no Windows wheels available at that time. (Still, there are no Windows packages on conda, but there are Linux packages, so one can think of installing from pip on Windows and conda otherwise/on LInux.) mamba is mentioned it seems. |
I just followed the instructions and it worked well. (Windows 11) Edit: I should mention that I have some things already installed via pip, but pikepdf and lxml were downloaded and installed, as I did not run Python 3.11 earlier as default.) However, something pulls in matplotlib-base as a dependency (I think via matplotlib-inline which I think comes from ipython), which is maybe not a big deal but would be nice to avoid if possible. Also, when installing, pip pulls in another version of numpy, certifi, pybind11, setuptools_scm, and packaging. This may be OK, but I think that these are actually installed "properly", not just as part of the build, so maybe they should be in environment as well? (numpy should of course be numpy_lowest_supported_version or whatever the name is.) |
That maybe the isolated build environment doing it's job. I'm torn if we should add |
I am arriving late to this, so I may not have the full picture. There is no need for I have just tried the latest |
That's what I thought would happen, but after building I can import pybind11 and setuptools_scm. But maybe I am missing something? |
Another thing here is that maybe one would like to point out a bit clearer how to get the Windows build dependencies. It is in the next section, but can be a bit confusing, I guess, if one follows it step by step. (On Linux and, I assume, Mac there is usually some sort of compiler installed.) Taking that if one needs help to install a compiler, it is probably the easiest to install the Visual Studio build environment (or whatever it is called), one may think of directly linking to the download page for that. |
Not sure if anyone is working on this, if not, I will take a look |
@hasanrashid that would be great, feel free to ping if you need any assistance! 😄 |
If you're having trouble setting up Matplotlib for development on Windows, there are a few steps you can try to troubleshoot the issue: Make sure you have the correct dependencies installed: Before installing Matplotlib, make sure you have the necessary dependencies, such as Python, NumPy, and a supported version of the Microsoft Visual C++ Redistributable for Visual Studio. Use a virtual environment: It's recommended to install Matplotlib in a virtual environment to avoid conflicts with other Python packages on your system. Check the file paths: Ensure that the file paths in the activation script match the actual file paths on your system. For example, if your virtual environment is located in a different folder than the one specified in the activation script, replace the file path in the script with the correct path to your virtual environment. Try using a different terminal: If the activation script is not working in the Command Prompt, try using a different terminal, such as the Windows PowerShell, and run the appropriate activation script for that terminal. Run the activation script as an administrator: If you're still having trouble activating the virtual environment, try right-clicking on the activation script and selecting "Run as administrator". |
Can you provide me a good resource to follow for making a virtual environment in python? |
@ashusnapx Thank you for the pointer. Here is where I am with this:
So, what would be the best way to solve this? remove pikepdf from environment.yml, or update documentation with this caveat + the venv instruction of using pip? |
@ashusnapx @melissawm Wanted to see if this still needed help. For me pikepdf never failed. I listed the behaviour I saw above. Do we still go ahead with removing the entries from the environment yml? |
Can I have my hands on this issue, I am new to open source and wanted to contribute |
So far we have 2 reports (@hasanrashid and @oscargus ) that things work as expected and hence no action is needed. @nitin-pandita I think the work we need here is (assuming you have a windows machine) is to verify that the instructions work for you and if they do we can close this issue! |
No problem @tacaswell , Please let me know if there is some other good first issue I can contribute to, as I mentioned early I'm new to Open source, and I would love to work under your guidance and support. Thank you @tacaswell |
Can you please suggest to me some good first issues as a beginner? I really wanted to get indulge in community work, I'm more into web Scrapping and Machine Learning |
@nitin-pandita we have guidance for contributors here: |
Hi, @tacaswell! I followed the windows instructions for both venv and conda (python 3.11.3) and there were no problems with either. Conda did take a bit longer though (~25 minutes as opposed to ~15 with venv). |
That makes 3 successes, so I think we can close this. |
Documentation Link
https://matplotlib.org/devdocs/devel/development_setup.html#create-a-dedicated-environment
Problem
The conda instructions do not work on windows:
The venv method does not include in information about how to install all of the dev dependencies
Suggested improvement
Possible options for conda:
Possible solution for venv:
pip install -r requirements/dev/dev-requirements.txt
The text was updated successfully, but these errors were encountered: