Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MNT]: Make _ttconv.convert_ttf_to_ps take a binary file as output argument, not a text file #25265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
anntzer opened this issue Feb 20, 2023 · 0 comments
Open

[MNT]: Make _ttconv.convert_ttf_to_ps take a binary file as output argument, not a text file #25265

anntzer opened this issue Feb 20, 2023 · 0 comments
Labels
backend: ps Maintenance status: waiting for other PR

Comments

@anntzer
Copy link
Contributor

anntzer commented Feb 20, 2023

Summary

convert_ttf_to_ps really outputs bytes, not str; the decoding as latin1 currently done (#25253) is meaningless if one really passed in a text file open with an ascii-incompatible encoding. Let's just make that function take a binary file as output arg instead.
See also https://github.com/matplotlib/matplotlib/pull/25253/files#r1111664168; probably this can wait for #25253 to be merged first.

Proposed fix

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend: ps Maintenance status: waiting for other PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anntzer