Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Doc]: Pyplot Axes – tuple or list? #26508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
EngineerKhan opened this issue Aug 12, 2023 · 6 comments · Fixed by #26521
Closed

[Doc]: Pyplot Axes – tuple or list? #26508

EngineerKhan opened this issue Aug 12, 2023 · 6 comments · Fixed by #26521
Labels
Documentation
Milestone
v3.8.0

Comments

@EngineerKhan
Copy link
Contributor

Documentation Link

https://matplotlib.org/stable/api/_as_gen/matplotlib.pyplot.axes.html

Problem

It reads: "4-tuple of floats rect = [left, bottom, width, height]. "

Shouldn't it be a list?

Suggested improvement

Perhaps we should go for the tuples here.
@rcomer
Copy link
Member

rcomer commented Aug 12, 2023

Thanks @EngineerKhan, I think either will work, but I agree this docstring should be self-consistent. Changing it as you say would make it match fig.add_axes (which it calls underneath). Would you like to make a PR?

@EngineerKhan
Copy link
Contributor Author

@rcomer I have made the PR. Please check if it sounds good.

@rcomer
Copy link
Member

rcomer commented Aug 14, 2023

@EngineerKhan I cannot see a pull request from you.

@EngineerKhan
Copy link
Contributor Author

@rcomer Maybe I done it wrongly? Can you please check it again?

@rcomer
Copy link
Member

rcomer commented Aug 14, 2023

@EngineerKhan it looks like you still need to create the pull request from your branch. If you go here then you should see a "New pull request" button.

@EngineerKhan
Copy link
Contributor Author

@rcomer My bad. I have made one now. Hope it's the right way to do it.

@rcomer rcomer linked a pull request Aug 14, 2023 that will close this issue
Replaced list with tuple in pyplot for axes #26521
Merged
5 tasks
@QuLogic QuLogic added this to the v3.8.0 milestone Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging a pull request may close this issue.

Replaced list with tuple in pyplot for axes EngineerKhan/matplotlib
3 participants
@QuLogic @EngineerKhan @rcomer