Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Doc]: ncols parameter hard-coded #26560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fostermaier opened this issue Aug 21, 2023 · 3 comments · Fixed by #26569
Closed

[Doc]: ncols parameter hard-coded #26560

fostermaier opened this issue Aug 21, 2023 · 3 comments · Fixed by #26569
Labels
Documentation Good first issue Open a pull request against these issues if there are no active ones!
Milestone

Comments

@fostermaier
Copy link

Documentation Link

https://matplotlib.org/stable/gallery/color/named_colors.html

Problem

I just copied the example code and changed the number of columns ncols.
It seems there are some hard coded 4s in the code.

Suggested improvement

change 4 s in

width = cell_width * 4 + 2 * margin

and
ax.set_xlim(0, cell_width * 4)

to ncols

@rcomer
Copy link
Member

rcomer commented Aug 21, 2023

Good spot @fostermaier! Would you like to make a pull request to fix it?

@rcomer rcomer added the Good first issue Open a pull request against these issues if there are no active ones! label Aug 21, 2023
@github-actions
Copy link

Good first issue - notes for new contributors

This issue is suited to new contributors because it does not require understanding of the Matplotlib internals. To get started, please see our contributing guide.

We do not assign issues. Check the Development section in the sidebar for linked pull requests (PRs). If there are none, feel free to start working on it. If there is an open PR, please collaborate on the work by reviewing it rather than duplicating it in a competing PR.

If something is unclear, please reach out on any of our communication channels.

@AmirAflak
Copy link
Contributor

would like to take this :)

@QuLogic QuLogic added this to the v3.7.3 milestone Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Good first issue Open a pull request against these issues if there are no active ones!
Projects
None yet
4 participants