Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Bug]: Incorrect X-axis scaling with date values #28341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pm13 opened this issue Jun 4, 2024 · 4 comments · Fixed by #28487
Closed

[Bug]: Incorrect X-axis scaling with date values #28341

pm13 opened this issue Jun 4, 2024 · 4 comments · Fixed by #28487
Labels
status: confirmed bug status: has patch patch suggested, PR still needed
Milestone
v3.9.1

Comments

@pm13
Copy link

pm13 commented Jun 4, 2024

Bug summary

In matplotlib 3.9.0, when plotting dates on the X-axis, calling axhspan unexpectedly expands the X-axis range from 1970 to 2024. This behavior did not occur in version 3.8.4, where the X-axis correctly ranges from 2020 to 2024.

Code for reproduction

import datetime
import matplotlib.pyplot as plt

x = [datetime.date(year, 1, 1) for year in range(2020, 2024)]
y = range(4)

plt.plot(x, y)
plt.axhspan(1, 2)

Actual outcome

3 9 0

Expected outcome

3 8 4

Additional information

No response

Operating system

Fedora

Matplotlib Version

3.9.0

Matplotlib Backend

inline or Agg

Python version

3.12.3

Jupyter version

4.2.1

Installation

pip
@timhoffm
Copy link
Member

timhoffm commented Jun 4, 2024

This is a regression in 3.9.

@ksunden
Copy link
Member

ksunden commented Jun 4, 2024

Most likely related to #26788

@QuLogic
Copy link
Member

QuLogic commented Jun 4, 2024

A bisect does indeed point to that commit; I'm a bit confused though as it seems like that change is supposed to try and avoid changing the datalimits, but maybe it's something to do with using date/units.

cc @anntzer

@anntzer
Copy link
Contributor

anntzer commented Jun 5, 2024

Woops. The fix is easy:

diff --git i/lib/matplotlib/axes/_axes.py w/lib/matplotlib/axes/_axes.py
index 9a2b367fb5..7efbd6562f 100644
--- i/lib/matplotlib/axes/_axes.py
+++ w/lib/matplotlib/axes/_axes.py
@@ -1028,7 +1028,7 @@ class Axes(_AxesBase):
         # For Rectangles and non-separable transforms, add_patch can be buggy
         # and update the x limits even though it shouldn't do so for an
         # yaxis_transformed patch, so undo that update.
-        ix = self.dataLim.intervalx
+        ix = self.dataLim.intervalx.copy()
         mx = self.dataLim.minposx
         self.add_patch(p)
         self.dataLim.intervalx = ix

(intervalx is an array and thus vulnerable to getting mutated in place). Note that axvspan already has the necessary copy() call, only axhspan was missing it.
Can you take over the patch?

@anntzer anntzer added the status: has patch patch suggested, PR still needed label Jun 11, 2024
@ksunden ksunden mentioned this issue Jun 12, 2024
Closed
@QuLogic QuLogic mentioned this issue Jun 28, 2024
Merged
2 tasks
@QuLogic QuLogic added this to the v3.9.1 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: confirmed bug status: has patch patch suggested, PR still needed
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging a pull request may close this issue.

Fix autoscaling with axhspan QuLogic/matplotlib
5 participants
@QuLogic @anntzer @ksunden @timhoffm @pm13