Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MNT]: set_dpi and get_dpi functions defined twice in figure.py #29909

Closed as not planned
@Guzzelius

Description

@Guzzelius

Summary

Hey,

I just stumbled over the fact that the methods 'set_dpi' and 'get_dpi' are defined twice in figure.py (first in lines 2257 foolwing and then in lines 3084 following:

They apear also twice in figure.pyi, once with the type: float and once without:
289: def get_dpi(self) -> float: ...
290: def set_dpi(self, val) -> None: ...
vs:
372: def get_dpi(self) -> float: ...
373: def set_dpi(self, val: float) -> None: ...

Maybe I am a noob and there is good reason, if not it should be cleaned up.

Proposed fix

If no good reason, delete one of them.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions