-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Update Selection Widgets #3486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@tonysyu, @tacaswell, what are your thoughts? |
Can you spilt them into as many PRs as make sense? My concern is that large PRs are hard to review (which makes it easier for bugs to slip in) and provide a larger cross section to collect conflicts (leading to more re-basing). Again, I apologize, I have not had the bandwidth to look in to this in any detail. |
@blink1073 just as a side note, this could be related #3475 |
Just to note, if you get this completed (I agree to break this up into
smaller PRs) within the next month, I'll be sure to include mention of
these new widgets in my book on interactive matplotlib
On Tue, Sep 9, 2014 at 10:42 AM, Federico Ariza [email protected]
|
@blink1073 be aware of #3376 |
It would be nice to merge #3376 first so I can build on that. |
I think what you did with image inspector is great, and a more unified API for selection widgets would be welcome. I agree with @tacaswell that small PRs would be much easier to review. Probably just the base |
Seems like there was great work done here, thanks and props @blink1073! What is the status of this particular issue? I'm assuming there weren't any other PRs to submit, in which case we should mark this closed. Please do comment if otherwise. |
Thanks, @petehuang! There is an open PR for the paint selector (#7411), to be followed by a PR for the line selector. I decided not to tackle the lasso selector integration after all. I'd say this particular PR can be closed. |
I took a stab at updating the selection widgets. Namely, improving the
RectangleSelector
andLassoSelector
, and adding newEllipseSelector
,PaintSelector
andLineSelector
widgets. These are based on a proof of concept I made called image inspector, which in turn is based on the scikit-image canvastools.I created a gist that demonstrates all the widgets.
Improvements to
RectangleSelector
:drawmode == 'line'
, actually draw the outline instead of a single lineThe API is the same, but the default
drawmode
has been changed to'patch'
, while allowing'box'
to alias to'patch'
. Also, the shape is no longer invisible after been drawn (so we can interact with it).Improvements to
LassoSelector
:RectangeSelector
polygon
mode where it draws straight linesNote that
LassoSelector
had two methods that were renamed:onpress
->press
andonrelease
->release
. The old methods could be kept, and call the new methods while giving a deprecation warning.Here is a screenshot of the Ellipse tool:

How would you like me to proceed? Throw them all into one PR?
The text was updated successfully, but these errors were encountered: