Support for Scalar Image Cursor Display? #3984

blink1073 · 2015-01-09T02:27:34Z

How would everyone feel about the following change? It will show the z value of a scalar image in the cursor if available (similar to what Matlab does). If there is no image or the image is RGB, it will revert to the previous behaviour.

--- a/lib/matplotlib/axes/_base.py
+++ b/lib/matplotlib/axes/_base.py
@@ -2971,7 +2971,12 @@ class _AxesBase(martist.Artist):
             ys = '???'
         else:
             ys = self.format_ydata(y)
-        return 'x=%s y=%s' % (xs, ys)
+        try:
+            z = self.images[0].get_array()[int(y + 0.5), int(x + 0.5)]
+            zs = self.format_xdata(z)
+            return 'x=%s y=%s z=%s' % (xs, ys, zs)
+        except:
+            return 'x=%s y=%s' % (xs, ys)

     def minorticks_on(self):
         'Add autoscaling minor ticks to the axes.'

The text was updated successfully, but these errors were encountered:

blink1073 · 2015-01-09T02:32:20Z

We could also add a fmt_zdata which falls back on format_xdata if None, so the user can directly change the z axis format:

--- a/lib/matplotlib/axes/_base.py
+++ b/lib/matplotlib/axes/_base.py
@@ -438,6 +438,7 @@ class _AxesBase(martist.Artist):
         # funcs used to format x and y - fall back on major formatters
         self.fmt_xdata = None
         self.fmt_ydata = None
+        self.fmt_zdata = None

         self.set_cursor_props((1, 'k'))  # set the cursor properties for axes

@@ -2971,7 +2972,13 @@ class _AxesBase(martist.Artist):
             ys = '???'
         else:
             ys = self.format_ydata(y)
-        return 'x=%s y=%s' % (xs, ys)
+        try:
+            z = self.images[0].get_array()[int(y + 0.5), int(x + 0.5)]
+            formatter = self.fmt_zdata or self.format_xdata
+            zs = formatter(z)
+            return 'x=%s y=%s z=%s' % (xs, ys, zs)
+        except:
+            return 'x=%s y=%s' % (xs, ys)

     def minorticks_on(self):

tacaswell · 2015-01-09T02:36:16Z

You need to also take the extent of the image into account.

WeatherGod · 2015-01-09T02:41:50Z

Yeah, it is a lot more complicated than that. I made an exa!mole demoing it
in my upcoming book, but it is incomplete in that it only recognizes the
last image added (doesn't take into account the zsort order).
On Jan 8, 2015 9:36 PM, "Thomas A Caswell" [email protected] wrote:

You need to also take the extent of the image into account.

—
Reply to this email directly or view it on GitHub
#3984 (comment)
.

WeatherGod · 2015-01-09T02:44:21Z

I should note that my example was partly based off of the functionality
provided by the mpldatacursor package.
On Jan 8, 2015 9:41 PM, "Benjamin Root" [email protected] wrote:

Yeah, it is a lot more complicated than that. I made an exa!mole demoing
it in my upcoming book, but it is incomplete in that it only recognizes the
last image added (doesn't take into account the zsort order).
On Jan 8, 2015 9:36 PM, "Thomas A Caswell" [email protected]
wrote:

You need to also take the extent of the image into account.

—
Reply to this email directly or view it on GitHub
#3984 (comment)
.

blink1073 · 2015-01-09T02:44:29Z

I hear this complaint from everyone I introduce to Python, so I'd really like to nail this down.

blink1073 · 2015-01-09T02:54:26Z

Hack so far based on mpldatacursor:

--- a/lib/matplotlib/axes/_base.py
+++ b/lib/matplotlib/axes/_base.py
@@ -438,6 +438,7 @@ class _AxesBase(martist.Artist):
         # funcs used to format x and y - fall back on major formatters
         self.fmt_xdata = None
         self.fmt_ydata = None
+        self.fmt_zdata = None

         self.set_cursor_props((1, 'k'))  # set the cursor properties for axes

@@ -2961,6 +2962,17 @@ class _AxesBase(martist.Artist):
             val = func(y)
             return val

+    def _get_z_coord(self, x, y):
+        im = self.images[0]
+        xmin, xmax, ymin, ymax = im.get_extent()
+        if im.origin == 'upper':
+            ymin, ymax = ymax, ymin
+        data_extent = mtransforms.Bbox([[ymin, xmin], [ymax, xmax]])
+        array_extent = mtransforms.Bbox([[0, 0], im.get_array().shape[:2]])
+        trans = mtransforms.BboxTransformFrom(data_extent) +\
+            mtransforms.BboxTransformTo(array_extent)
+        return trans.transform_point([y,x]).astype(int)
+
     def format_coord(self, x, y):
         """Return a format string formatting the *x*, *y* coord"""
         if x is None:
@@ -2971,7 +2983,14 @@ class _AxesBase(martist.Artist):
             ys = '???'
         else:
             ys = self.format_ydata(y)
-        return 'x=%s y=%s' % (xs, ys)
+        try:
+            i, j = self._get_z_coord(x, y)
+            z = self.images[0].get_array()[i, j]
+            formatter = self.fmt_zdata or self.format_xdata
+            zs = formatter(z)
+            return 'x=%s y=%s z=%s' % (xs, ys, zs)
+        except:
+            return 'x=%s y=%s' % (xs, ys)

     def minorticks_on(self):
         'Add autoscaling minor ticks to the axes.'

blink1073 · 2015-01-09T02:57:13Z

With zorder handling:

--- a/lib/matplotlib/axes/_base.py
+++ b/lib/matplotlib/axes/_base.py
@@ -438,6 +438,7 @@ class _AxesBase(martist.Artist):
         # funcs used to format x and y - fall back on major formatters
         self.fmt_xdata = None
         self.fmt_ydata = None
+        self.fmt_zdata = None

         self.set_cursor_props((1, 'k'))  # set the cursor properties for axes

@@ -2961,6 +2962,16 @@ class _AxesBase(martist.Artist):
             val = func(y)
             return val

+    def _get_z_coord(self, im, x, y):
+        xmin, xmax, ymin, ymax = im.get_extent()
+        if im.origin == 'upper':
+            ymin, ymax = ymax, ymin
+        data_extent = mtransforms.Bbox([[ymin, xmin], [ymax, xmax]])
+        array_extent = mtransforms.Bbox([[0, 0], im.get_array().shape[:2]])
+        trans = mtransforms.BboxTransformFrom(data_extent) +\
+            mtransforms.BboxTransformTo(array_extent)
+        return trans.transform_point([y,x]).astype(int)
+
     def format_coord(self, x, y):
         """Return a format string formatting the *x*, *y* coord"""
         if x is None:
@@ -2971,7 +2982,15 @@ class _AxesBase(martist.Artist):
             ys = '???'
         else:
             ys = self.format_ydata(y)
-        return 'x=%s y=%s' % (xs, ys)
+        try:
+            im = self.images[np.argmax([im.zorder for im in self.images])]
+            i, j = self._get_z_coord(im, x, y)
+            z = im.get_array()[i, j]
+            formatter = self.fmt_zdata or self.format_xdata
+            zs = formatter(z)
+            return 'x=%s y=%s z=%s' % (xs, ys, zs)
+        except:
+            return 'x=%s y=%s' % (xs, ys)

     def minorticks_on(self):
         'Add autoscaling minor ticks to the axes.'

tacaswell · 2015-01-09T03:00:05Z

All artists have picker logic, you could probably hi-jack that to sort out which, if any of the you are in and then take the top one of that sub-set.

This may be why no one has done this yet (obnoxious demanding devs) ;)

blink1073 · 2015-01-09T03:02:04Z

So basically all of mpldatacursor then...

blink1073 · 2015-01-09T03:14:29Z

The problem I see is that we don't have an event, which is needed by the picking logic and is used extensively by mpldatacursor.

tacaswell · 2015-01-09T03:16:40Z

We should have a mouse motion event (as that is what is updating the
formatter).

On Thu Jan 08 2015 at 10:14:31 PM Steven Silvester [email protected]
wrote:

The problem I see is that we don't have an event, which is needed by
the picking logic and is used extensively by mpldatacursor.

—
Reply to this email directly or view it on GitHub
#3984 (comment)
.

blink1073 · 2015-01-09T03:18:01Z

So we'd need to plug in here:

./backend_bases.py:2790: s = event.inaxes.format_coord(event.xdata, event.ydata)

blink1073 · 2015-01-09T03:18:59Z

Get the s message there and then get an optional add-on message based on the artist...

blink1073 · 2015-01-09T03:23:08Z

Shucks, there is no artist assigned to a motion_notify_event.

tacaswell · 2015-01-09T03:34:51Z

This is some-what related to the discussion in #2986 in that we were talking about (iirc with out re-reading it in detail) a way to stack the message strings from multiple axes, not just the 'top' one of a twin{x,y} pair.

This should also be linked to #3146

blink1073 · 2015-01-09T03:35:08Z

Here's what I see:
We look through all of the artists on event.inaxes, checking contains. Then we grab the largest in zorder.

blink1073 · 2015-01-09T03:40:00Z

This should handle #3416, but all we know about is event.inaxes. Is there a way to detect if an axes has a twin? If so, we could use your suggested ax1: x.... | ax2: x... display and run this same algo on both axes.

blink1073 · 2015-01-09T03:43:11Z

@tacaswell, what zdata would you want about other artist types? The size of an element?

blink1073 · 2015-01-09T03:48:29Z

Here's what I've got so far:

--- a/lib/matplotlib/backend_bases.py
+++ b/lib/matplotlib/backend_bases.py
@@ -2791,6 +2791,13 @@ class NavigationToolbar2(object):
             except (ValueError, OverflowError):
                 pass
             else:
+                ax = event.inaxes
+                artists = ax.artists + ax.images + ax.lines
+                artists = [a for a in artists if a.contains(event)[0]]
+                if artists:
+                    artist = artists[np.argmax([a.zorder for a in artists])]
+                    print(artist)
+
                 if len(self.mode):
                     self.set_message('%s, %s' % (self.mode, s))
                 else:

WeatherGod · 2015-01-09T03:50:26Z

You guys are just trying to obsolete my book before it comes out, aren't
you? Can't you wait until the 2nd edition? ;-)
On Jan 8, 2015 10:43 PM, "Steven Silvester" [email protected]
wrote:

@tacaswell https://github.com/tacaswell, what zdata would you want
about other artist types? The size of an element?

—
Reply to this email directly or view it on GitHub
#3984 (comment)
.

blink1073 · 2015-01-09T04:01:21Z

Here's a working example that handles just images:

--- a/lib/matplotlib/backend_bases.py
+++ b/lib/matplotlib/backend_bases.py
@@ -51,6 +51,7 @@ from matplotlib import get_backend
 from matplotlib._pylab_helpers import Gcf

 from matplotlib.transforms import Bbox, TransformedBbox, Affine2D
+import matplotlib.transforms as mtransforms

 import matplotlib.tight_bbox as tight_bbox
 import matplotlib.textpath as textpath
@@ -2781,6 +2782,26 @@ class NavigationToolbar2(object):

                 self._lastCursor = cursors.MOVE

+    def _get_z_data(self, event):
+        images = event.inaxes.images
+        images = [im for im in images if im.contains(event)[0]]
+        if not images:
+            return ''
+        im = images[np.argmax([i.zorder for i in images])]
+        xmin, xmax, ymin, ymax = im.get_extent()
+        if im.origin == 'upper':
+            ymin, ymax = ymax, ymin
+        data_extent = mtransforms.Bbox([[ymin, xmin], [ymax, xmax]])
+        array_extent = mtransforms.Bbox([[0, 0], im.get_array().shape[:2]])
+        trans = mtransforms.BboxTransformFrom(data_extent) +\
+            mtransforms.BboxTransformTo(array_extent)
+        i, j = trans.transform_point([event.ydata, event.xdata]).astype(int)
+        z = im.get_array()[i, j]
+        if z.size > 1:
+            # Override default numpy formatting for this specific case. Bad idea?
+            z = ', '.join('{:0.3g}'.format(item) for item in z)
+        return 'z=%s' % z
+
     def mouse_move(self, event):
         self._set_cursor(event)

@@ -2791,6 +2812,7 @@ class NavigationToolbar2(object):
             except (ValueError, OverflowError):
                 pass
             else:
+                s += self._get_z_data(event)
                 if len(self.mode):
                     self.set_message('%s, %s' % (self.mode, s))
                 else:

tacaswell · 2015-01-09T04:02:54Z

@blink1073 The proper OO way would be to add a no-op function to Artist to and then let artists sub-classes process the motion event and return their addition to the message.

blink1073 · 2015-01-09T04:05:17Z

I sense a PR coming...

blink1073 · 2015-01-09T04:05:51Z

What if there are multiple images though? Don't we still need a zorder arbiter?

tacaswell · 2015-01-09T04:07:32Z

Yeah, it should probably figure out which of the artists it is over and then only ask the top artist to add an entry to the message. This will also help arbitrate when we have multiple crossing lines or lines on top of images, etc.

blink1073 · 2015-01-09T04:08:46Z

I think we should still check for contains, then check zorder, then ask that artist for its additional message, no?

blink1073 · 2015-01-09T04:09:37Z

Ah, I see that is what you already said...

blink1073 mentioned this issue Jan 9, 2015

Allow Artists to show pixel data in cursor display #3989

Merged

tacaswell added status: needs revision and removed status: needs revision labels Jan 19, 2015

tacaswell added status: needs review status: needs revision and removed status: needs review labels Jan 19, 2015

tacaswell added this to the next point release milestone Feb 19, 2015

tacaswell added In Progress and removed status: needs revision labels Feb 19, 2015

OceanWolf mentioned this issue Mar 27, 2015

Twin axis message coordinates #4284

Closed

tacaswell closed this as completed in #3989 May 24, 2015

tacaswell removed the In Progress label May 24, 2015

Uh oh!

Support for Scalar Image Cursor Display? #3984

Support for Scalar Image Cursor Display? #3984

Comments

blink1073 commented Jan 9, 2015

blink1073 commented Jan 9, 2015

Uh oh!

tacaswell commented Jan 9, 2015

Uh oh!

WeatherGod commented Jan 9, 2015

Uh oh!

WeatherGod commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

tacaswell commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

tacaswell commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

tacaswell commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

WeatherGod commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

tacaswell commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

tacaswell commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!

blink1073 commented Jan 9, 2015

Uh oh!