-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
FreeType checking for unix #4062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Autodrive Sorry, reading that message after I posted it comes across as way more hostile than I intended! That message is mostly notes the other devs. |
From your first comment, I could learn about prior similar ones. |
@Autodrive Yes, but I should have been friendlier about it. |
@tacaswell - you missed #3363, which also deals with Freetype (specifically getting the correct version string). @Autodrive - I think it might be helpful if you could provide a PR which shows the kind of thing you had in mind (it doesn't have to be complete, just something to give focused feedback - it may be that by doing that we get some more information on the problem). Cheers! |
On Mac there is an issue when pkg config is not installed. I tried fixing it in #3713 but it breaks other stuff. |
I can't give a definitive answer. If your change would be invasive, I'd target the master branch, otherwise if this is a bugfix with little impact other than making a specific case better, then the v1.4.x branch would be the target. Stick it against master for now, and we can always back port. Cheers, |
Definitely against master. @efiring made a compelling case that 1.4.3 should be the last maintenance release and we should just start working on 1.5 now. |
Based on the linked issues, I think |
1.4.2 may have difficulty locating freetype2 on unix if pkg_config is not installed (correctly). To make the installation more robust, what about adding get_extension method to the FreeType class of setupext.py file?
The text was updated successfully, but these errors were encountered: