-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Polar plot error bars don't rotate with angle #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As of mpl 1.2.1 the error bar itself does align with theta, but the error bar cap does not. The cap is implemented as a marker, so either we need a way to specify the rotation of markers, or the cap needs to be implemented as a LineCollection, or perhaps as a gappy line. |
This is still the state on master |
@isomerase I think it's only correct for you because you are using a style that hides the caps. The caps are still not rotated on master. |
Still a bug 😞 but less visible now that the default style has no caps. |
Just trying to understand the state of this issue: is this still open and scheduled for a future release? Could I submit a PR with a fix? |
I'm pretty sure this is still open, so if you have a fix a PR would be very appreciated! |
Thanks for the reply, @dstansby. I just did some tests including my patch on the source code (version 2.1.2), and it seems to fix this problem in my plots, and the OP's plot without changing their script. An example using polar coordinates would be good too, what do you think? Also, I may have some minor questions, is gitter an appropriate channel for that? |
yes, gitter is great for dev chat, including minor dev questions. |
Progress, @thmosqueiro? It is OK to submit a PR that is "Work in Progress", if that can help move it along. |
Hi @efiring. Apologies for the delay, I had to relocate recently. I actually have a local version that works and fixes the issues I had, and the issue originally reported. I like this idea of a "Work in Progress" kind of PR. I will post more info within a couple of days. |
Hi @thmosqueiro, I was wondering if you had managed to find some time to do this? If you haven't got the time to invest, could you share your code and I can go through the process of getting updated? Many thanks |
@thmosqueiro If you and @RoryIAngus could come up with a PR that solves this problem cleanly, that would be much appreciated. I would love to be able to close this issue, which dates back to 2011. |
@efiring my current employment is prohibitive regarding open source contributions. I however would not mind sharing what I have done until before I got hired, which is documented and could be finalized by someone else. I talked to @jaquejbrito and she's interested in taking over my code and take responsibility over this task. I can most definitely provide her with feedback IRL and in here. Also, I'm sure if @RoryIAngus wants to also contribute, she'd be glad to have someone else to work with. So @efiring she says that she could get started as soon as tomorrow. Sounds good? |
Thank you. |
I would love to be of assistance.
|
Hi. |
Some code to recreate the error showing the end cap issue and how it is not rotating but staying aligned to the horizontal plane.
|
Thanks for the sample code. I’m taking a look at thiago’s code, and should be able to stage his current changes in a forked repository soon. |
Hey, @jaquejbrito, any progress related? |
In this example the errorbars do not align with the theta of bar. I posted this as a question at stackoverflow, and maybe the answer could be useful. Surely, this should not be default behavior though.
Example non-working code:
The text was updated successfully, but these errors were encountered: