Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reorder #includes in ttconv/pprdrv_tt2.cpp #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jdh2358 opened this issue Oct 14, 2011 · 3 comments
Closed

Reorder #includes in ttconv/pprdrv_tt2.cpp #526

jdh2358 opened this issue Oct 14, 2011 · 3 comments

Comments

@jdh2358
Copy link
Collaborator

jdh2358 commented Oct 14, 2011

From matplotlib-devel posted by [email protected]

Attached is patch that moves :

#include <cstdlib>

to before:

#include <cmath>

The Portland group compiler (v 11.8) won't build ttconv/pprdrv_tt2.cpp with the original ordering.
This is most likely a compiler bug, but changing the include order seems pretty harmless.
@mdboom
Copy link
Member

mdboom commented Oct 14, 2011

Seems harmless to me.

@jdh2358
Copy link
Collaborator Author

jdh2358 commented Oct 14, 2011

Alright, I'll test and push to v1.1.x

jdh2358 added a commit to jdh2358/matplotlib that referenced this issue Oct 14, 2011
@jdh2358
reorder imports in ttconv to work around portland group compiler issu…
96033e6 
…e (see issue matplotlib#526)
@jdh2358
Copy link
Collaborator Author

jdh2358 commented Oct 14, 2011

Probably not significant enough to merit a pull request, but a foolish consistency is the hobgoblin of little minds. all tests passed after change....

#527

@jdh2358 jdh2358 closed this as completed Oct 14, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdboom @jdh2358