Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove --nocapture from nosetests on .travis.yml? #5337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdboom opened this issue Oct 28, 2015 · 2 comments
Closed

Remove --nocapture from nosetests on .travis.yml? #5337

mdboom opened this issue Oct 28, 2015 · 2 comments
Assignees

Comments

@mdboom
Copy link
Member

mdboom commented Oct 28, 2015

As mentioned in #5324 (comment), we are passing the -s or --nocapture flag to nose when we run the tests on Travis. This causes the output of any tests to be printed immediately rather than with its failure block at the end of the run. On the one hand, this can be nice if the test run is failing catastrophically (e.g. a segfault) because we know what printed right before the process died. On the other hand, with the "running inside of gdb" functionality we have now, we will at least get a nice traceback when that happens.

I'm inclined to turn off -s, but I wanted to confirm there weren't good current reasons for keeping it on.

It seems to have been added by @pelson in b8bc21f

@tacaswell
Copy link
Member

👍 It makes even less sense now that we print dots instead of the test names (which we do so that travis will render our test logs).

@pelson
Copy link
Member

pelson commented Oct 30, 2015

Yep, I'm ok with this. 👍

@mdboom mdboom self-assigned this Oct 30, 2015
@mdboom mdboom closed this as completed in 142cfdc Nov 2, 2015
jenshnielsen added a commit that referenced this issue Nov 2, 2015
Fix #5337.  Turn off --no-capture (-s) on nose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants