Mac: Save button not working on 1.5.0 or 2.x with backend.qt4 in ipython 4 #5689

JCorson · 2015-12-17T01:46:49Z

When trying to save a figure in matplotlib 1.5.0 with backend:Qt4Agg and backend.qt4:PySide the save button is not functional. The save dialog opens and then immediately closes.

# Use %matplotlib to prevent segfault reported in issue #5687
%matplotlib 
import matplotlib.pyplot as plt
plt.plot(range(10))

Click the save button.
plt.savefig() still works.
I have been able to reproduce this behavior on Mac (OSX 10.11) in both Enthought and Anaconda's matplotlib 1.5.0.

The text was updated successfully, but these errors were encountered:

tacaswell · 2015-12-17T05:02:52Z

just to confirm, this is a regression from 1.4.3?

jdmarch · 2015-12-17T14:02:34Z

I can reproduce on 1.4.3

tacaswell · 2015-12-17T14:23:24Z

ok, so not a regression.

This is tickling something in the back of my mind as having seen this before and it getting fixed, but details are not forth coming.

attn @mfitzp

mdboom · 2015-12-21T21:41:51Z

I can't seem to reproduce with Homebrew Python 2.7.11 and pyside. What Python are you using and how did you install PySide?

mdboom · 2015-12-21T21:42:57Z

Nevermind, if I run in IPython, I can reproduce. Regular Python interpreter works, though.

tacaswell · 2015-12-22T15:45:12Z

I wonder if this is related to the ipython inputhook?

On Mon, Dec 21, 2015, 16:43 Michael Droettboom [email protected]
wrote:

Nevermind, if I run in IPython, I can reproduce. Regular Python
interpreter works, though.

—
Reply to this email directly or view it on GitHub
#5689 (comment)
.

mdboom · 2015-12-22T16:54:09Z

That's my suspicion, but I haven't had much time to look at it.

Fix save button in GUIs closes #5689

mdboom · 2015-12-23T16:35:19Z

Sorry -- I think I introduced confusion by not being clear enough in the PR descriptions. d041565 doesn't fix this bug. This bug has to do with the save dialog displaying briefly. d041565 (and #5720) fix a bug that only happens after the user has had a chance to select a filename and begin drawing and saving the file. I've been poking at this bug without any success -- I think it's something pretty low-level in how the IPython input hook is set up, and (I think) used to work and recent PySide changes broke it.

tacaswell · 2015-12-23T16:36:04Z

sorry 🐑

mdboom · 2015-12-23T16:37:23Z

No worries. It would be hard to know they were different from the descriptions alone.

tacaswell · 2016-01-01T22:10:34Z

Punting this to the 2.0 tag as it is not a regression and we probably need to pull in someone from IPython here.

@JCorson #5690 fixed the segfault, does this bug exist using the not-ipython-eventhook?

JCorson · 2016-01-05T15:17:10Z

@tacaswell with #5690 patched, I have only been able to produce this bug when running ipython with %pylab or %matplotlib.

tacaswell · 2016-01-05T16:24:58Z

@Carreau who is the right IPython person to ping about input hook + qt + pyside issues?

Carreau · 2016-01-05T16:27:34Z

hum... I take my chance with @minrk that know all the things. I'll have a look too.

efiring · 2016-06-20T02:03:59Z

This is not a pyside-specific issue; I see it with an Anaconda installation using pyqt 4.11.4. @minrk, any chance you can look into this?

tacaswell · 2016-06-20T02:06:20Z

I think this may be a OSX specific issue as well. It works correctly on linux.

minrk · 2016-06-20T06:58:47Z

I'll see what I can find out.

tiagopereira · 2016-10-05T13:35:20Z

I had this problem with both PySide and PyQt. However, updating to IPython 5.1.0 seems to solve the issue. Also improves the window redraw when resized on qt5.

efiring · 2016-12-23T07:51:18Z

I can reproduce it using ipython with or without '--pylab' or any gui magic (plt.ion()), but not at the ordinary python prompt, where plt.ion() is now sufficient for interactivity. This is with ipython 4.0.3, so given the report above, it may be something we don't have to worry about, as newer ipython versions come into use.

anntzer · 2017-06-29T21:12:32Z

Closing as the last report is that this is fixed with recent ipython versions. Feel free to reopen if still present with even more recent ipythons.

tacaswell added this to the Critical bugfix release (1.5.1) milestone Dec 17, 2015

tacaswell added the GUI: Qt label Dec 17, 2015

tacaswell added the not a blocker label Dec 17, 2015

mdboom self-assigned this Dec 21, 2015

tacaswell added a commit that referenced this issue Dec 23, 2015

Merge pull request #5720 from mdboom/fix-save-button

2695ea5

Fix save button in GUIs closes #5689

tacaswell closed this as completed in d041565 Dec 23, 2015

mdboom reopened this Dec 23, 2015

tacaswell modified the milestones: next major release (2.0), Critical bugfix release (1.5.1) Jan 1, 2016

tacaswell modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Jan 25, 2016

efiring changed the title ~~Mac: Save button not working on 1.5.0 with backend.qt4:PySide~~ Mac: Save button not working on 1.5.0 or 2.x with backend.qt4 Dec 23, 2016

efiring changed the title ~~Mac: Save button not working on 1.5.0 or 2.x with backend.qt4~~ Mac: Save button not working on 1.5.0 or 2.x with backend.qt4 in ipython 4 Dec 23, 2016

QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0.2 (next bug fix release) May 3, 2017

anntzer closed this as completed Jun 29, 2017

Uh oh!

Mac: Save button not working on 1.5.0 or 2.x with backend.qt4 in ipython 4 #5689

Mac: Save button not working on 1.5.0 or 2.x with backend.qt4 in ipython 4 #5689

Comments

JCorson commented Dec 17, 2015

tacaswell commented Dec 17, 2015

Uh oh!

jdmarch commented Dec 17, 2015

Uh oh!

tacaswell commented Dec 17, 2015

Uh oh!

mdboom commented Dec 21, 2015

Uh oh!

mdboom commented Dec 21, 2015

Uh oh!

tacaswell commented Dec 22, 2015

Uh oh!

mdboom commented Dec 22, 2015

Uh oh!

mdboom commented Dec 23, 2015

Uh oh!

tacaswell commented Dec 23, 2015

Uh oh!

mdboom commented Dec 23, 2015

Uh oh!

tacaswell commented Jan 1, 2016

Uh oh!

JCorson commented Jan 5, 2016

Uh oh!

tacaswell commented Jan 5, 2016

Uh oh!

Carreau commented Jan 5, 2016

Uh oh!

efiring commented Jun 20, 2016

Uh oh!

tacaswell commented Jun 20, 2016

Uh oh!

minrk commented Jun 20, 2016

Uh oh!

tiagopereira commented Oct 5, 2016

Uh oh!

efiring commented Dec 23, 2016

Uh oh!

anntzer commented Jun 29, 2017

Uh oh!