Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Better choice of axes offset value #5755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anntzer opened this issue Dec 29, 2015 · 3 comments
Closed

Better choice of axes offset value #5755

anntzer opened this issue Dec 29, 2015 · 3 comments
Milestone
v2.0.0

Comments

@anntzer
Copy link
Contributor

anntzer commented Dec 29, 2015

Currently, when setting xlim(1231, 1239), the offset text is "+1.231e3" and the x labels are 0, ..., 8. I would suggest switching this to +1230 and x labels being 1, ..., 9. There is a formatting issue (basically using "%g" instead of "%f"), but I want to concentrate here on the actual value of the offset.

Basically, I think a reasonable algorithm for the choice of the offset value is the following:
(1) if xmin and xmax have the same number of digits: use the longest common prefix of their string representations, padded by zeros (e.g. xyzabc .. xyzdef => xyz000).
(2) if they don't have the same number of digits (e.g. 9995 .. 10005), I see two possibilities: either fall back to using 9995 as base offset, or use 10000 as base offset in which case the x labels will go from -5 to +5. I tend to think the second option is better but it is true that negative labels can look weird.
(3) note that using negative labels is also an option in case (1) if the number of zeros in the padding is "large" relative to the x range, e.g. 12399995 .. 12400005: it may be better to use 12400000 as base offset and have x labels from -5 to +5 rather than 12300000 as base offset and have x labels from 99995 to 100005.

Thoughts?

Related to #4445, #4451, #5738.
@mdboom
Copy link
Member

mdboom commented Dec 29, 2015

This is a long-standing problem, and as you point out in #5738 is now going to be much more prevalent.

As for thoughts, I guess it might be useful to make a draft PR that we could all kick at and see how it helps in various contexts.

This was referenced Dec 30, 2015
Closed
Merged
@tacaswell
Copy link
Member

Note of promise of test against #5780

@tacaswell tacaswell modified the milestones: proposed next point release (2.1), next major release (2.0) Jan 1, 2016
anntzer added a commit to anntzer/matplotlib that referenced this issue Jan 2, 2016
@anntzer
Better choice of offset-text.
5f69ed8 
The axis offset text is choosen as follows:

xlims => offsettext
123, 189 => 0
12341, 12349 => 12340
99999.5, 100010.5 => 100000 # (also a test for matplotlib#5780)
99990.5, 100000.5 => 100000
1233999, 1234001 => 1234000

(and the same for negative limits).

See matplotlib#5755.
anntzer added a commit to anntzer/matplotlib that referenced this issue Jan 2, 2016
@anntzer
Better choice of offset-text.
d6e9f80 
The axis offset text is choosen as follows:

xlims => offsettext
123, 189 => 0
12341, 12349 => 12340
99999.5, 100010.5 => 100000 # (also a test for matplotlib#5780)
99990.5, 100000.5 => 100000
1233999, 1234001 => 1234000

(and the same for negative limits).

See matplotlib#5755.
anntzer added a commit to anntzer/matplotlib that referenced this issue Jan 2, 2016
@anntzer
Better choice of offset-text.
56026ae 
The axis offset text is chosen as follows:

xlims => offsettext
123, 189 => 0
12341, 12349 => 12340
99999.5, 100010.5 => 100000 # (also a test for matplotlib#5780)
99990.5, 100000.5 => 100000
1233999, 1234001 => 1234000

(and the same for negative limits).

See matplotlib#5755.
@anntzer anntzer mentioned this issue Jan 2, 2016
Merged
anntzer added a commit to anntzer/matplotlib that referenced this issue Jan 7, 2016
@anntzer
Better choice of offset-text.
c73a275 
The axis offset text is chosen as follows:

xlims => offsettext
123, 189 => 0
12341, 12349 => 12340
99999.5, 100010.5 => 100000 # (also a test for matplotlib#5780)
99990.5, 100000.5 => 100000
1233999, 1234001 => 1234000

(and the same for negative limits).

See matplotlib#5755.
anntzer added a commit to anntzer/matplotlib that referenced this issue Jan 27, 2016
@anntzer
Better choice of offset-text.
226b996 
The axis offset text is chosen as follows:

xlims => offsettext
123, 189 => 0
12341, 12349 => 12340
99999.5, 100010.5 => 100000 # (also a test for matplotlib#5780)
99990.5, 100000.5 => 100000
1233999, 1234001 => 1234000

(and the same for negative limits).

See matplotlib#5755.
anntzer added a commit to anntzer/matplotlib that referenced this issue Feb 18, 2016
@anntzer
Better choice of offset-text.
691e680 
The axis offset text is chosen as follows:

xlims => offsettext
123, 189 => 0
12341, 12349 => 12340
99999.5, 100010.5 => 100000 # (also a test for matplotlib#5780)
99990.5, 100000.5 => 100000
1233999, 1234001 => 1234000

(and the same for negative limits).

See matplotlib#5755.
anntzer added a commit to anntzer/matplotlib that referenced this issue May 2, 2016
@anntzer
Better choice of offset-text.
9a4ecfb 
The axis offset text is chosen as follows:

xlims => offsettext
123, 189 => 0
12341, 12349 => 12340
99999.5, 100010.5 => 100000 # (also a test for matplotlib#5780)
99990.5, 100000.5 => 100000
1233999, 1234001 => 1234000

(and the same for negative limits).

See matplotlib#5755.
@anntzer
Copy link
Contributor Author

anntzer commented May 11, 2016

Closed by #5785.

@anntzer anntzer closed this as completed May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
3 participants
@mdboom @tacaswell @anntzer