-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
add xkcd style #5992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Comic Neue should fit that requirement. I've been trying to figure out how to get it working on FreeBSD (and failing). |
I would like to work on the issue.How do I start? |
@souravsingh Awesome I suggest having a look at the existing styles (.sty) files in https://github.com/matplotlib/matplotlib/tree/master/lib/matplotlib/mpl-data/stylelib to see how they work. The code that defines the pyplot.xkcd is here: https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/pyplot.py#L353 so as a first step you can copy the rc params changes from there into a .sty file. |
This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help! |
This still seems like something we should have. |
@rcomer Perhaps we can decide whether we want to move forward with #14943 (or something along these lines) -- I don't really want to spend time arguing for it anymore. If we really don't want python style files, even restricted to matplotlib's own styles, then I think we should close this as effectively unfixable (because instantiating patheffects, even declaratively, necessarily means importing a python class and thus running arbitrary python code). |
What could speak against python style files:
Both aspects do not apply as long as we keep python style files internal. - I think this is a good way forward a) to provide Thus I support going forward with interal python style files. We can later decide whether we want to make this public as well. |
OK, I rebased and reopened #14943, let's discuss that over there. |
This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help! |
Can't believe we don't have this one already. Not perfectly trivial, as we would need a way to specify the special patheffect from the rcfile, but, essentially, this would replace
plt.xkcd()
.Should also look into finding an open font that we can package that matches Humor Sans.
The text was updated successfully, but these errors were encountered: