Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improving documentation: Tests failing on a osx setup #7234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NelleV opened this issue Oct 7, 2016 · 4 comments · Fixed by #7236
Closed

Improving documentation: Tests failing on a osx setup #7234

NelleV opened this issue Oct 7, 2016 · 4 comments · Fixed by #7236
Assignees
@NelleV
Labels
Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Documentation
Milestone
v2.0.0

Comments

@NelleV
Copy link
Member

NelleV commented Oct 7, 2016 •
edited
Loading

We've ran into some problems getting the matplotlib environment working fine on linux, and I am not sure this is documented anywhere.

We had a massive number of tests failing, as the tests where not running on the correct freetype issue. The fix was easy:

  1. edit the setup.cfg file and set the test to True, and local_freetype to true.
  2. Delete the old build - matplotlib caches the results and will not rebuild with the new options despite they changed.
  3. Rebuild.

Our documentation need to be updated to reflect this issue.

Original issue.

On system python2.7.8, on latest master version, with both the macosx and agg backend, @trpham is having a lot of tests failing on images comparisons:

======================================================================
FAIL: mpl_toolkits.tests.test_axes_grid1.test_inset_locator(0, u'inset_locator', u'png')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Library/Python/2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/Users/TruongPham/BIDS/matplotlib/lib/matplotlib/testing/nose/decorators.py", line 60, in failer
    result = f(*args, **kwargs)
  File "/Users/TruongPham/BIDS/matplotlib/lib/matplotlib/testing/decorators.py", line 297, in compare
    raise_on_image_difference(expected_fname, actual_fname, self.tol)
  File "/Users/TruongPham/BIDS/matplotlib/lib/matplotlib/testing/decorators.py", line 216, in raise_on_image_difference
    '(RMS %(rms).3f)' % err)
ImageComparisonFailure: images not close: /Users/TruongPham/BIDS/matplotlib/result_images/test_axes_grid1/inset_locator.png vs. /Users/TruongPham/BIDS/matplotlib/result_images/test_axes_grid1/inset_locator-expected.png (RMS 0.001)

Around 900 tests are failing, but the RMS is always extremely small. Anyone guesses what is going on?

Apart from this, matplotlib seems to be running fine. Any help would be appreciated.
@NelleV
Copy link
Member Author

NelleV commented Oct 7, 2016

It might be a freetype issue.

@NelleV
Copy link
Member Author

NelleV commented Oct 7, 2016

It was a freetype issue.
I'll document this properly.

@NelleV NelleV changed the title Tests failing on a osx setup Improving documentation: Tests failing on a osx setup Oct 7, 2016
@NelleV NelleV added Documentation Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues labels Oct 7, 2016
@tacaswell
Copy link
Member

There is also an enviromental variable.

Some of this is documented at http://matplotlib.org/devdocs/devel/testing.html#building-matplotlib-for-image-comparison-tests (but does not seem to be in the currently built docs).

@NelleV
Copy link
Member Author

NelleV commented Oct 8, 2016

I am working on improving the contributors documentation right now to be able to point to one page for new contributors. I've highly inspired myself from the scikit-learn documentation, and a work in progress can be found here:
http://cbio.mines-paristech.fr/~nvaroquaux/tmp/matplotlib/devel/contributing.html

@NelleV NelleV mentioned this issue Oct 8, 2016
Merged
5 tasks
@QuLogic QuLogic added this to the 2.0.1 (next bug fix release) milestone Nov 2, 2016
cfackler pushed a commit to cfackler/matplotlib that referenced this issue Nov 3, 2016
@NelleV @cfackler
ENH Improved contributing documentation
02282e1 
closes matplotlib#7234
bcongdon pushed a commit to bcongdon/matplotlib that referenced this issue Nov 8, 2016
@NelleV @bcongdon
ENH Improved contributing documentation
f2f7741 
closes matplotlib#7234
bcongdon pushed a commit to bcongdon/matplotlib that referenced this issue Nov 8, 2016
@NelleV @bcongdon
ENH Improved contributing documentation
3a6083e 
closes matplotlib#7234
@QuLogic QuLogic modified the milestones: 2.0 (style change major release), 2.0.1 (next bug fix release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NelleV NelleV

Labels
Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Documentation
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

ENH Improving the contribution guidelines
4 participants
@mdboom @NelleV @tacaswell @QuLogic