-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Data types not preserved in categoricals #9350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I am not super concerned about this, it is string catagoricals. |
Which brings us back to @anntzer's earlier suggestion that we should raise an error instead of accepting this nonsensical input. |
I agree that's a bug, but the issue seems to be that the second positional parameter is ambiguous. Like it's technically doing the correct thing, given that this works the exact same way: plt.fill_between([0, 1, 2], [2, 3, 2], 0) What I mean is plt.fill_between(['a', 'b', 'c'], ['e', 'f', 'g'], 'r') Errors out spectacularly because it tries to do a lookup on 'r' against the existing mapping and doesn't see it as a new value:
Also, it's not hitting the update and instead going straight to the convert, which is why this isn't working either:
ETA: Ok, I think your point is that once I've set the yaxis to being scaler, it should have a flag of sorts that all other values passed to it need to use the same units? That seems reasonable/I agree. |
Closed by #9783 Still some broken edge cases (which we have tests for now). |
Uh oh!
There was an error while loading. Please reload this page.
@anntzer pointed out on #9340 that the behavior for

plt.plot([23, "23"])
should be two data points with identical labels. Currently it collapses them into one value:The text was updated successfully, but these errors were encountered: