-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
idle_event is invoked only once #959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It looks like so little of the idle_event machinery is implemented that it might be best to rip out what is there, none of which seems to be functional in any way. |
It's good to know this is broken -- I have big plans for it. There was discussion at Scipy of having a "draft mode" that would switch on during panning and zooming (to make it faster) and then have it do a high-quality rendering on idle once the panning stops. So there's a good use case for it -- but clearly it's broken. I'm happy to look into why as part of the above work when I get to it. |
@mdboom What is the state of this? |
The docs say idle_event is deprecated (http://matplotlib.org/examples/event_handling/idle_and_timeout.html), so is the issue this is referring to still exist? |
Closing as we have fully deprecated idle_event as of #8454. |
FigureCanvasBase.idle_event doesn't return anything, meaning it is only called once under the gtk backend. This leads to the apparent breakage of which means examples/idle_and_timeout.py is broken.
All in all it seems that the idle_event callback is incompletely implemented at best. It's quite unclear whether it's even a good idea to pipe this event through CallbackRegistry, since we only really want the backend to register it (with, e.g., gobject.idle_add) if there is a callback to be called. Otherwise we are just creating unnecessary work by executing a stub function.
The text was updated successfully, but these errors were encountered: