Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Determine if hinting_factor setting can be dropped #9681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
QuLogic opened this issue Nov 4, 2017 · 3 comments · May be fixed by #29816
Open

Determine if hinting_factor setting can be dropped #9681

QuLogic opened this issue Nov 4, 2017 · 3 comments · May be fixed by #29816
Labels
keep Items to be ignored by the “Stale” Github Action topic: text
Milestone
future releases

Comments

@QuLogic
Copy link
Member

QuLogic commented Nov 4, 2017

While working out #9481, @anntzer and I have come to the conclusion that the hinting_factor setting is a relic of a different time when FreeType rendering was not so great. In essence, it causes horizontal rendering to be done at high resolution and then scaled down. However, it is not entirely clear that it is still necessary to do so.

Additionally, tests disable hinting but enable this factor (at 8x scaling). The default style enables both hinting and this factor. This makes it a bit difficult to say what the end effect would be overall.
@jklymak jklymak added this to the v2.2 milestone Nov 7, 2017
@QuLogic QuLogic modified the milestones: v2.2, v3.0 Feb 10, 2018
@tacaswell tacaswell modified the milestones: v3.0, v3.1 Aug 11, 2018
@anntzer anntzer modified the milestones: v3.1.0, v3.2.0 Feb 25, 2019
@anntzer anntzer mentioned this issue Jun 13, 2019
Closed
6 tasks
@anntzer anntzer mentioned this issue Jul 26, 2019
Closed
@tacaswell tacaswell modified the milestones: v3.2.0, needs sorting Sep 10, 2019
@anntzer anntzer mentioned this issue Aug 21, 2020
Closed
@github-actions
Copy link

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Apr 23, 2023
@anntzer anntzer added the keep Items to be ignored by the “Stale” Github Action label Apr 23, 2023
@anntzer
Copy link
Contributor

anntzer commented Apr 23, 2023

We should just drop it once we can regen the entire suite of baseline images (#14538).

@rcomer rcomer removed the status: inactive Marked by the “Stale” Github Action label May 21, 2023
@QuLogic
Copy link
Member Author

QuLogic commented Apr 3, 2025

It looks like font.hinting_factor came in with #719, but that was simply the addition of an rcParam for something that was already hardcoded. And someone found that hinting_factor=1 with default hinting mode looked better. I might try out what they have as well.

See #29816 (comment) for the effect of removing this setting.

@QuLogic QuLogic linked a pull request Apr 3, 2025 that will close this issue
Update FreeType to 2.13.3 #29816
Open
5 tasks
@QuLogic QuLogic linked a pull request Apr 4, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keep Items to be ignored by the “Stale” Github Action topic: text
Projects
None yet
Milestone
future releases
Development

Successfully merging a pull request may close this issue.

Update FreeType to 2.13.3 QuLogic/matplotlib
5 participants
@tacaswell @QuLogic @anntzer @jklymak @rcomer