Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MacOS: Key modifiers deprecated #9837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jklymak opened this issue Nov 22, 2017 · 0 comments · Fixed by #21512
Closed

MacOS: Key modifiers deprecated #9837

jklymak opened this issue Nov 22, 2017 · 0 comments · Fixed by #21512
Labels
GUI: MacOSX
Milestone
v3.6.0

Comments

@jklymak
Copy link
Member

jklymak commented Nov 22, 2017

Bug report

Issue

A heads up that modifiers like:

matplotlib/src/_macosx.m

Lines 2601 to 2607 in 813d842

NSMutableString* returnkey = [NSMutableString string];
if ([event modifierFlags] & NSControlKeyMask)
[returnkey appendString:@"ctrl+" ];
if ([event modifierFlags] & NSAlternateKeyMask)
[returnkey appendString:@"alt+" ];
if ([event modifierFlags] & NSCommandKeyMask)
[returnkey appendString:@"cmd+" ];

are deprecated:

https://developer.apple.com/documentation/appkit/nseventmodifierflags?language=objc

and probably need to be replaced by the flags like NSEventModifierFlagCommand etc.

I'd change, but I'm not sure how this will affect older OS X installs etc...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GUI: MacOSX
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging a pull request may close this issue.

MNT: Add modifier key press handling to macosx backend greglucas/matplotlib
3 participants
@tacaswell @QuLogic @jklymak