Don't bother disconnecting idle_draw at gtk shutdown. #15777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the canvas has already been destroyed this leads to a warning
("Source ID xxx was not found when attempting to remove it").
repro:
MPLBACKEND=gtk3agg python -c 'from pylab import *; fig = plt.figure(); plot(); show(); fig.savefig("/tmp/test.png")'
This may cause an additional call to idle_draw(), but idle_draw() (via
draw()) first checks `self.is_drawable()` which would return False for
destroyed (thus not visible anymore) widgets
(https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-is-drawable)
so it's just a noop.
tacaswell
approved these changes
Dec 8, 2019
timhoffm
approved these changes
Dec 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the canvas has already been destroyed this leads to a warning
("Source ID xxx was not found when attempting to remove it").
repro:
MPLBACKEND=gtk3agg python -c 'from pylab import *; fig = plt.figure(); plot(); show(); fig.savefig("/tmp/test.png")'
This may cause an additional call to idle_draw(), but idle_draw() (via
draw()) first checks
self.is_drawable()which would return False fordestroyed (thus not visible anymore) widgets
(https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-is-drawable)
so it's just a noop.
Closes #15773.
PR Summary
PR Checklist