From 12bef746d4c8dcb990f60bbded1f306f6d709dc9 Mon Sep 17 00:00:00 2001 From: Elliott Sales de Andrade Date: Tue, 28 Jul 2020 00:28:32 -0400 Subject: [PATCH 1/3] ci: Add tee to debug reviewdog. --- .github/workflows/reviewdog.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index d235cec9c2e5..15a3d864ee2b 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -29,7 +29,7 @@ jobs: REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | flake8 --docstring-convention=all | \ - reviewdog -f=pep8 -name=flake8 -reporter=github-check + reviewdog -f=pep8 -name=flake8 -tee -reporter=github-check eslint: name: eslint From 0c4a0d226152f796c81c5cd8d9c18815f3281d96 Mon Sep 17 00:00:00 2001 From: Elliott Sales de Andrade Date: Tue, 28 Jul 2020 00:35:01 -0400 Subject: [PATCH 2/3] ci: Disable filtering of lint errors. For certain reporters, it's necessary to do this filtering because GitHub does not allow posting to unrelated files. The github-check reporter _should_ allow it though, and we want to catch things like unused imports that may not be in the diff. --- .github/workflows/reviewdog.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index 15a3d864ee2b..a6fee8cfebfc 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -29,7 +29,8 @@ jobs: REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | flake8 --docstring-convention=all | \ - reviewdog -f=pep8 -name=flake8 -tee -reporter=github-check + reviewdog -f=pep8 -name=flake8 \ + -tee -reporter=github-check -filter-mode nofilter eslint: name: eslint @@ -40,6 +41,7 @@ jobs: - name: eslint uses: reviewdog/action-eslint@v1 with: + filter_mode: nofilter github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-check workdir: 'lib/matplotlib/backends/web_backend/' From 3eb47795668c4b3d92d0b5eca17c53a87d998a13 Mon Sep 17 00:00:00 2001 From: Elliott Sales de Andrade Date: Tue, 28 Jul 2020 00:42:09 -0400 Subject: [PATCH 3/3] Fix flake8 issues. --- lib/matplotlib/axes/_axes.py | 8 ++++---- lib/matplotlib/rcsetup.py | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py index 720b421bef90..5660e474b018 100644 --- a/lib/matplotlib/axes/_axes.py +++ b/lib/matplotlib/axes/_axes.py @@ -830,8 +830,8 @@ def axhline(self, y=0, xmin=0, xmax=1, **kwargs): """ self._check_no_units([xmin, xmax], ['xmin', 'xmax']) if "transform" in kwargs: - raise ValueError("'transform' is not allowed as a keyword argument; " - "axhline generates its own transform.") + raise ValueError("'transform' is not allowed as a keyword " + "argument; axhline generates its own transform.") ymin, ymax = self.get_ybound() # We need to strip away the units for comparison with @@ -899,8 +899,8 @@ def axvline(self, x=0, ymin=0, ymax=1, **kwargs): """ self._check_no_units([ymin, ymax], ['ymin', 'ymax']) if "transform" in kwargs: - raise ValueError("'transform' is not allowed as a keyword argument; " - "axvline generates its own transform.") + raise ValueError("'transform' is not allowed as a keyword " + "argument; axvline generates its own transform.") xmin, xmax = self.get_xbound() # We need to strip away the units for comparison with diff --git a/lib/matplotlib/rcsetup.py b/lib/matplotlib/rcsetup.py index 4b25c37ab9a1..ad807d72a89f 100644 --- a/lib/matplotlib/rcsetup.py +++ b/lib/matplotlib/rcsetup.py @@ -18,7 +18,6 @@ import logging from numbers import Number import operator -import os import re import numpy as np