From e0e3ccb340b7a7362c4fb08526c53882cb991150 Mon Sep 17 00:00:00 2001 From: Elliott Sales de Andrade Date: Tue, 11 Aug 2020 21:50:05 -0400 Subject: [PATCH] Set pipefail when running flake8 linter. This ensures that the lint will fail if flake8 is broken, otherwise default bash behaviour is to ignore it, if reviewdog exits cleanly. --- .github/workflows/reviewdog.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index a6fee8cfebfc..ba142edd6aed 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -28,6 +28,7 @@ jobs: env: REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | + set -o pipefail flake8 --docstring-convention=all | \ reviewdog -f=pep8 -name=flake8 \ -tee -reporter=github-check -filter-mode nofilter