Rework interactive backends tests. #18908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the long test-scripts to separate functions and extract their source using `inspect.getsource` to pass that to the subprocess; this avoids having really long source snippets in strings and lets us have e.g. syntax highlighting on them. - Use ThreadPoolExecutor in test_interactive_thread_safety / _test_thread_impl which provides a much simpler (basically automatic) API to rethrow exceptions from within the thread.
timhoffm
approved these changes
Nov 6, 2020
| _test_timeout = 10 # Empirically, 1s is not enough on Travis. | ||
|
|
||
|
|
||
| # The source of this function gets extracted and run in another process, so it |
There was a problem hiding this comment.
That's not really a doc about the function but rather a comment about how it needs to be implemented?
There was a problem hiding this comment.
IMHO that's splitting hairs. But no strong opinion either way.
Comment on lines
+93
to
+94
| assert_equal = TestCase().assertEqual | ||
| assert_raises = TestCase().assertRaises |
There was a problem hiding this comment.
You can't, because this is run in another (non-pytest) subprocess so pytest magic-subsitution doesn't happen here.
There was a problem hiding this comment.
Fair point. We might want to put a comment on this.
QuLogic
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the long test-scripts to separate functions and extract their
source using
inspect.getsourceto pass that to the subprocess; thisavoids having really long source snippets in strings and lets us have
e.g. syntax highlighting on them.
Use ThreadPoolExecutor in test_interactive_thread_safety /
_test_thread_impl which provides a much simpler (basically automatic)
API to rethrow exceptions from within the thread.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).