Improve square state calculation in RectangleSelector #21920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1884cf9 to
46b96ae
Compare
timhoffm
approved these changes
Dec 10, 2021
ericpre
approved these changes
Dec 11, 2021
There was a problem hiding this comment.
I remember that I have tried something like that, but I came to the conclusion that it wasn't possible and I had to revert to the original implementation. However, it does seem to work now and this is may possible because of changes related to this: either with use_data_coordinates or with the aspect ratio correction or both combined! The test suite seems to cover the potentially problematic cases and I tested it manually and everything is working fine!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I think this is the correct way of doing the calculation, and avoids potential division by zero issues with the previous implementation.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).