From 49dd3aac0e3fce2b132a30d1d6c5a0a244b93c62 Mon Sep 17 00:00:00 2001 From: Elliott Sales de Andrade Date: Tue, 10 Oct 2023 23:35:23 -0400 Subject: [PATCH] ci: Clean up Python 3.12 builds The final release is out, as are non-prerelease wheels, so we can drop those workarounds. --- .github/workflows/cibuildwheel.yml | 14 -------------- .github/workflows/tests.yml | 15 ++++++--------- 2 files changed, 6 insertions(+), 23 deletions(-) diff --git a/.github/workflows/cibuildwheel.yml b/.github/workflows/cibuildwheel.yml index 3b141f934e29..cdb62658e6c9 100644 --- a/.github/workflows/cibuildwheel.yml +++ b/.github/workflows/cibuildwheel.yml @@ -143,20 +143,6 @@ jobs: env: CIBW_BUILD: "cp312-*" CIBW_ARCHS: ${{ matrix.cibw_archs }} - # Remove this once NumPy with Python 3.12 wheels is not pre-release. - CIBW_BEFORE_BUILD: >- - pip install "meson-python>=0.13.1" ninja "pybind11>=2.6" "setuptools>=42" "setuptools_scm>=7" && - pip install --pre "numpy>=1.25" && - rm -rf {package}/build - CIBW_BEFORE_BUILD_WINDOWS: >- - pip install delvewheel "meson-python>=0.13.1" ninja "pybind11>=2.6" "setuptools>=42" "setuptools_scm>=7" && - pip install --pre "numpy>=1.25" && - rm -rf {package}/build - CIBW_ENVIRONMENT: PIP_NO_BUILD_ISOLATION=0 - # Remove this once contourpy has Python 3.12 wheels. - CIBW_BEFORE_TEST: >- - pip install "meson>=1.2.0" "meson-python>=0.13.1" "ninja" "pybind11>=2.10.4" && - pip install --pre "numpy>=1.25" - name: Build wheels for CPython 3.11 uses: pypa/cibuildwheel@fff9ec32ed25a9c576750c91e06b410ed0c15db7 # v2.16.2 diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index a3d3d63c64fa..614f9235a5a4 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -77,9 +77,8 @@ jobs: pyside6-ver: '!=6.5.1' extra-requirements: '-r requirements/testing/extra.txt' - os: ubuntu-22.04 - python-version: '3.12-dev' + python-version: '3.12' pyside6-ver: '!=6.5.1' - pre: true - os: macos-latest python-version: 3.9 # https://bugreports.qt.io/projects/PYSIDE/issues/PYSIDE-2346 @@ -196,10 +195,8 @@ jobs: python -m pip install --upgrade pip setuptools wheel # Install pre-release versions during our weekly upcoming dependency tests. - # Also install for 3.12 to get working NumPy (remove when 1.26 is released) - if [[ "${{ github.event_name == 'schedule' && - matrix.name-suffix != '(Minimum Versions)' }}" = "true" - || "${{ matrix.pre }}" = "true" ]]; then + if [[ "${{ github.event_name }}" == 'schedule' + && "${{ matrix.name-suffix }}" != '(Minimum Versions)' ]]; then PRE="--pre" fi @@ -241,7 +238,7 @@ jobs: echo 'PyQt5 is available' || echo 'PyQt5 is not available' if [[ "${{ runner.os }}" != 'macOS' - && "${{ matrix.python-version != '3.12-dev'}}" = "true" ]]; then + && "${{ matrix.python-version }}" != '3.12' ]]; then python -mpip install --upgrade pyside2${{ matrix.pyside2-ver }} && python -c 'import PySide2.QtCore' && echo 'PySide2 is available' || @@ -254,14 +251,14 @@ jobs: echo 'PyQt6 is not available' fi if [[ "${{ runner.os }}" != 'macOS' - && "${{ matrix.python-version != '3.12-dev'}}" = "true" ]]; then + && "${{ matrix.python-version }}" != '3.12' ]]; then python -mpip install --upgrade pyside6${{ matrix.pyside6-ver }} && python -c 'import PySide6.QtCore' && echo 'PySide6 is available' || echo 'PySide6 is not available' fi - if [[ "${{ matrix.python-version != '3.12-dev'}}" = "true" ]]; then + if [[ "${{ matrix.python-version }}" != '3.12' ]]; then python -mpip install --upgrade \ -f "https://extras.wxpython.org/wxPython4/extras/linux/gtk3/${{ matrix.os }}" \ wxPython &&