From 0d0f3c233d4f95ade5dd4e9d25f169c9f14f157f Mon Sep 17 00:00:00 2001 From: Junpei Ota Date: Tue, 24 Oct 2023 22:09:44 -0400 Subject: [PATCH 1/3] Added smoke tests for errorbar --- lib/matplotlib/tests/test_datetime.py | 38 ++++++++++++++++++++++++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/lib/matplotlib/tests/test_datetime.py b/lib/matplotlib/tests/test_datetime.py index f42e0a0d04d8..0116ba42524b 100644 --- a/lib/matplotlib/tests/test_datetime.py +++ b/lib/matplotlib/tests/test_datetime.py @@ -129,11 +129,43 @@ def test_contourf(self): fig, ax = plt.subplots() ax.contourf(...) - @pytest.mark.xfail(reason="Test for errorbar not written yet") @mpl.style.context("default") def test_errorbar(self): - fig, ax = plt.subplots() - ax.errorbar(...) + mpl.rcParams["date.converter"] = "concise" + fig, (ax1, ax2, ax3, ax4) = plt.subplots(4, 1, layout="constrained") + limit = 7 + start_date = datetime.datetime(2023, 1, 1) + + x_dates = np.array([datetime.datetime(2023, 10, delta) for delta in range(1, limit)]) + y_dates = np.array([datetime.datetime(2023, 10, delta) for delta in range(1, limit)]) + x_date_error = datetime.timedelta(days=1) + y_date_error = datetime.timedelta(days=1) + + x_values = list(range(1, limit)) + y_values = list(range(1, limit)) + x_value_error = 0.5 + y_value_error = 0.5 + + ax1.errorbar(x_dates, y_values, + yerr=y_value_error, + capsize=10, + barsabove=True, + label='Data') + + ax2.errorbar(x_values, y_dates, + xerr=x_value_error, yerr=y_date_error, + errorevery=(1, 2), + fmt='-o', label='Data') + + ax3.errorbar(x_dates, y_dates, + xerr=x_date_error, yerr=y_date_error, + lolims=True, xlolims=True, + label='Data') + + ax4.errorbar(x_dates, y_values, + xerr=x_date_error, yerr=y_value_error, + uplims=True, xuplims=True, + label='Data') @pytest.mark.xfail(reason="Test for eventplot not written yet") @mpl.style.context("default") From 1727e8d6c5581a5d2373a1e8768c6d21554f1e49 Mon Sep 17 00:00:00 2001 From: Junpei Ota Date: Tue, 24 Oct 2023 22:29:05 -0400 Subject: [PATCH 2/3] Fixed code formatting --- lib/matplotlib/tests/test_datetime.py | 33 ++++++++++++--------------- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/lib/matplotlib/tests/test_datetime.py b/lib/matplotlib/tests/test_datetime.py index b544ae49e047..1dfb1131364f 100644 --- a/lib/matplotlib/tests/test_datetime.py +++ b/lib/matplotlib/tests/test_datetime.py @@ -216,8 +216,8 @@ def test_errorbar(self): limit = 7 start_date = datetime.datetime(2023, 1, 1) - x_dates = np.array([datetime.datetime(2023, 10, delta) for delta in range(1, limit)]) - y_dates = np.array([datetime.datetime(2023, 10, delta) for delta in range(1, limit)]) + x_dates = np.array([datetime.datetime(2023, 10, d) for d in range(1, limit)]) + y_dates = np.array([datetime.datetime(2023, 10, d) for d in range(1, limit)]) x_date_error = datetime.timedelta(days=1) y_date_error = datetime.timedelta(days=1) @@ -227,25 +227,22 @@ def test_errorbar(self): y_value_error = 0.5 ax1.errorbar(x_dates, y_values, - yerr=y_value_error, - capsize=10, - barsabove=True, - label='Data') - + yerr=y_value_error, + capsize=10, + barsabove=True, + label='Data') ax2.errorbar(x_values, y_dates, - xerr=x_value_error, yerr=y_date_error, - errorevery=(1, 2), - fmt='-o', label='Data') - + xerr=x_value_error, yerr=y_date_error, + errorevery=(1, 2), + fmt='-o', label='Data') ax3.errorbar(x_dates, y_dates, - xerr=x_date_error, yerr=y_date_error, - lolims=True, xlolims=True, - label='Data') - + xerr=x_date_error, yerr=y_date_error, + lolims=True, xlolims=True, + label='Data') ax4.errorbar(x_dates, y_values, - xerr=x_date_error, yerr=y_value_error, - uplims=True, xuplims=True, - label='Data') + xerr=x_date_error, yerr=y_value_error, + uplims=True, xuplims=True, + label='Data') @pytest.mark.xfail(reason="Test for eventplot not written yet") @mpl.style.context("default") From 931bf748c26d3c9ad205c4affc2785631c656fd1 Mon Sep 17 00:00:00 2001 From: Junpei Ota Date: Tue, 24 Oct 2023 22:31:14 -0400 Subject: [PATCH 3/3] Removed Trailing Whitespace --- lib/matplotlib/tests/test_datetime.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/matplotlib/tests/test_datetime.py b/lib/matplotlib/tests/test_datetime.py index 1dfb1131364f..47c54c1389be 100644 --- a/lib/matplotlib/tests/test_datetime.py +++ b/lib/matplotlib/tests/test_datetime.py @@ -211,7 +211,7 @@ def test_contourf(self): @mpl.style.context("default") def test_errorbar(self): - mpl.rcParams["date.converter"] = "concise" + mpl.rcParams["date.converter"] = "concise" fig, (ax1, ax2, ax3, ax4) = plt.subplots(4, 1, layout="constrained") limit = 7 start_date = datetime.datetime(2023, 1, 1) @@ -226,20 +226,20 @@ def test_errorbar(self): x_value_error = 0.5 y_value_error = 0.5 - ax1.errorbar(x_dates, y_values, + ax1.errorbar(x_dates, y_values, yerr=y_value_error, capsize=10, - barsabove=True, + barsabove=True, label='Data') - ax2.errorbar(x_values, y_dates, + ax2.errorbar(x_values, y_dates, xerr=x_value_error, yerr=y_date_error, errorevery=(1, 2), fmt='-o', label='Data') - ax3.errorbar(x_dates, y_dates, + ax3.errorbar(x_dates, y_dates, xerr=x_date_error, yerr=y_date_error, lolims=True, xlolims=True, label='Data') - ax4.errorbar(x_dates, y_values, + ax4.errorbar(x_dates, y_values, xerr=x_date_error, yerr=y_value_error, uplims=True, xuplims=True, label='Data')