From 60a21233dacb22315daffcae1addf9b52853cc82 Mon Sep 17 00:00:00 2001 From: Elliott Sales de Andrade Date: Fri, 8 Dec 2023 00:29:36 -0500 Subject: [PATCH 1/2] Fix test visualization tool for non-PNG files For non-PNG files, our test diffing code creates a failed diff with a suffix of `_{ext}-failed-diff.png`, but the expected image has a suffix of `-expected_{ext}.png`. The test visualization was not correctly handling this difference. --- tools/triage_tests.py | 2 +- tools/visualize_tests.py | 33 ++++++++++++++++++++++++--------- 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/tools/triage_tests.py b/tools/triage_tests.py index d44d6fd743ea..5153b1c712cb 100644 --- a/tools/triage_tests.py +++ b/tools/triage_tests.py @@ -241,7 +241,7 @@ def __init__(self, path, root, source): if basename.endswith(f'_{ext}'): display_extension = f'_{ext}' extension = ext - basename = basename[:-4] + basename = basename[:-len(display_extension)] break else: display_extension = '' diff --git a/tools/visualize_tests.py b/tools/visualize_tests.py index 5ff3e0add97b..72948d67fb1f 100644 --- a/tools/visualize_tests.py +++ b/tools/visualize_tests.py @@ -10,6 +10,8 @@ import os from collections import defaultdict +# Non-png image extensions +NON_PNG_EXTENSIONS = ['pdf', 'svg', 'eps'] html_template = """