Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add test_quiver in test_datetime.py #27547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

add test_quiver in test_datetime.py #27547

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c85826f
update test_datetime
Elllllllvin Dec 20, 2023
58ecf03
update test_datetime
Elllllllvin Dec 20, 2023
326ae5d
update test_datetime
Elllllllvin Dec 20, 2023
5ee96e4
remove duplicate code
Elllllllvin Jan 23, 2024
83eefee
Merge branch 'matplotlib:main' into elllllllvin
Elllllllvin Jan 23, 2024
4f1dcb8
remove duplicate code
Elllllllvin Jan 23, 2024
ef71ef5
Update lib/matplotlib/tests/test_datetime.py
Elllllllvin Jan 23, 2024
b5f4080
update
Elllllllvin Jan 23, 2024
db32e40
update
Elllllllvin Jan 23, 2024
1f2684b
update
Elllllllvin Jan 23, 2024
10998f5
Update lib/matplotlib/tests/test_datetime.py
Elllllllvin Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions lib/matplotlib/tests/test_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,11 +464,28 @@ def test_plot_date(self):
ax2.plot_date(x_dates, y_ranges)
ax3.plot_date(x_ranges, y_dates)

@pytest.mark.xfail(reason="Test for quiver not written yet")
@mpl.style.context("default")
def test_quiver(self):
fig, ax = plt.subplots()
ax.quiver(...)
threshold = 10
fig, (ax1, ax2, ax3) = plt.subplots(3, 1, layout="constrained")

x_dates = np.array(
[datetime.datetime(2023, 11, 1+delta) for delta in range(threshold)]
)
y_dates = np.array(
[datetime.datetime(2023, 12, 1+delta) for delta in range(threshold)]
)
x_ranges = np.array(range(threshold))
y_ranges = np.array(range(threshold))
x_ranges = np.array(range(threshold))
y_ranges = np.array(range(threshold))
Copy link
Member

@dstansby dstansby Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x_ranges = np.array(range(threshold))
y_ranges = np.array(range(threshold))

These two lines can be removed as they're duplicates of the two lines above.

Copy link
Author

@Elllllllvin Elllllllvin Jan 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reply, I have just removed two extra lines , but the auto-checks seems failed.. it is about Pull Request Labeler / labeler (pull_request_target) , I have tried several times but can't find reasons


U = np.sin(np.arange(len(x_dates)))
V = np.cos(np.arange(len(y_dates)))

ax1.quiver(x_dates, y_ranges, U, V, scale=20)
ax2.quiver(x_ranges, y_dates, U, V, scale=20)
ax3.quiver(x_dates, y_dates, U, V, scale=20)

@pytest.mark.xfail(reason="Test for quiverkey not written yet")
@mpl.style.context("default")
Expand Down