From da6647be69e2018dd92f6de6df7f6c6146174e70 Mon Sep 17 00:00:00 2001
From: Antony Lee <anntzer.lee@gmail.com>
Date: Mon, 12 May 2025 12:46:32 +0200
Subject: [PATCH] Fix alpha compositing in ft2font's draw_bitmap.

The old formula (`*dst |= *src`) works fine when either dst or src is
full transparent or fully opaque, but not for compositing intermediate
values.  Fix that (while keeping a fast-path for the common case of
writing on an empty buffer).

Example (note the more uniform gray zone between the two letters):
```
from matplotlib import pyplot as plt, ft2font as f, cbook
import numpy as np

font = f.FT2Font(str(cbook._get_data_path("fonts/ttf/DejaVuSans.ttf")))
font.set_size(24, 72)
im = f.FT2Image(30, 30)
ga = font.load_char(ord("A"))
gv = font.load_char(ord("V"))
font.draw_glyph_to_bitmap(im, 2, 2, ga)
font.draw_glyph_to_bitmap(im, 12, 2, gv)

(plt.figure(layout="constrained", figsize=(3, 3))
 .add_subplot(xticks=[], yticks=[])
 .imshow(np.asarray(im), cmap="gray"))
plt.show()
```
---
 src/ft2font.cpp | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/ft2font.cpp b/src/ft2font.cpp
index 94c554cf9f63..20fe9a083bb6 100644
--- a/src/ft2font.cpp
+++ b/src/ft2font.cpp
@@ -104,6 +104,16 @@ void FT2Image::resize(long width, long height)
     }
 }
 
+static std::array<uint8_t, 0x10000> const alpha_cov_merge_table{[]() {
+    auto table = std::array<uint8_t, 0x10000>{};
+    for (auto dst = 0; dst < 0x100; ++dst) {
+        for (auto src = 0; src < 0x100; ++src) {
+            table[(dst << 8) + src] = dst + src - (dst * src + 0x7f) / 0xff;
+        }
+    }
+    return table;
+} ()};
+
 void FT2Image::draw_bitmap(FT_Bitmap *bitmap, FT_Int x, FT_Int y)
 {
     FT_Int image_width = (FT_Int)m_width;
@@ -124,7 +134,8 @@ void FT2Image::draw_bitmap(FT_Bitmap *bitmap, FT_Int x, FT_Int y)
             unsigned char *dst = m_buffer + (i * image_width + x1);
             unsigned char *src = bitmap->buffer + (((i - y_offset) * bitmap->pitch) + x_start);
             for (FT_Int j = x1; j < x2; ++j, ++dst, ++src)
-                *dst |= *src;
+                // Provide a fast-path for the common case of black background.
+                *dst = *dst ? alpha_cov_merge_table[(*dst << 8) + *src] : *src;
         }
     } else if (bitmap->pixel_mode == FT_PIXEL_MODE_MONO) {
         for (FT_Int i = y1; i < y2; ++i) {